Patch Detail
Show a patch.
GET /api/1.1/patches/9053/?format=api
{ "id": 9053, "url": "https://patchwork.libcamera.org/api/1.1/patches/9053/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9053/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200728234225.3505868-5-niklas.soderlund@ragnatech.se>", "date": "2020-07-28T23:42:25", "name": "[libcamera-devel,v3,5/5] libcamera: camera_manager: Enforce unique camera names", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b362fc77a50ea983e21f5f6e22c7c6b7de16af18", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9053/mbox/", "series": [ { "id": 1158, "url": "https://patchwork.libcamera.org/api/1.1/series/1158/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1158", "date": "2020-07-28T23:37:39", "name": "libcamera: Generate unique and stable camera names", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1158/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9053/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9053/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4969BBD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Jul 2020 23:42:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D02A461988;\n\tWed, 29 Jul 2020 01:42:44 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2CF8611A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Jul 2020 01:42:40 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 06084592-d12c-11ea-8fb8-005056917f90;\n\tWed, 29 Jul 2020 01:42:40 +0200 (CEST)" ], "X-Halon-ID": "06084592-d12c-11ea-8fb8-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 29 Jul 2020 01:42:25 +0200", "Message-Id": "<20200728234225.3505868-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200728234225.3505868-1-niklas.soderlund@ragnatech.se>", "References": "<20200728233744.3503740-1-niklas.soderlund@ragnatech.se>\n\t<20200728234225.3505868-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 5/5] libcamera: camera_manager: Enforce\n\tunique camera names", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The camera name have always been documented that it should be unique but\nit has never been enforced. Change this by refuse to add cameras to the\nCameraManager that would create two cameras with the exact same name.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/camera_manager.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex f60491d2c1a7500f..7d83263f1fabf5da 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -178,10 +178,10 @@ void CameraManager::Private::addCamera(std::shared_ptr<Camera> camera,\n \n \tfor (std::shared_ptr<Camera> c : cameras_) {\n \t\tif (c->name() == camera->name()) {\n-\t\t\tLOG(Camera, Warning)\n-\t\t\t\t<< \"Registering camera with duplicate name '\"\n+\t\t\tLOG(Camera, Error)\n+\t\t\t\t<< \"Skip registering camera with duplicated name '\"\n \t\t\t\t<< camera->name() << \"'\";\n-\t\t\tbreak;\n+\t\t\treturn;\n \t\t}\n \t}\n \n", "prefixes": [ "libcamera-devel", "v3", "5/5" ] }