Patch Detail
Show a patch.
GET /api/1.1/patches/9024/?format=api
{ "id": 9024, "url": "https://patchwork.libcamera.org/api/1.1/patches/9024/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9024/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200727162143.31317-4-kgupta@es.iitr.ac.in>", "date": "2020-07-27T16:21:43", "name": "[libcamera-devel,v4,3/3] libcamera: stream_option: use format name to set cam/qcam format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "831a8732b2adb134950aa3070aada7d64cf39981", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/1.1/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9024/mbox/", "series": [ { "id": 1153, "url": "https://patchwork.libcamera.org/api/1.1/series/1153/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1153", "date": "2020-07-27T16:21:40", "name": "Enable formats lookup based on name", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1153/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9024/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9024/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91EDABD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Jul 2020 16:22:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C93F611A2;\n\tMon, 27 Jul 2020 18:22:05 +0200 (CEST)", "from mail-pg1-x541.google.com (mail-pg1-x541.google.com\n\t[IPv6:2607:f8b0:4864:20::541])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE7F7605B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Jul 2020 18:22:03 +0200 (CEST)", "by mail-pg1-x541.google.com with SMTP id t6so9957106pgq.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Jul 2020 09:22:03 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tn14sm15811266pgd.78.2020.07.27.09.22.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Jul 2020 09:22:01 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=es-iitr-ac-in.20150623.gappssmtp.com\n\theader.i=@es-iitr-ac-in.20150623.gappssmtp.com\n\theader.b=\"U6hHlBrB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Vujycd8EPvoebCgjNl2OyNBkTEe2zGIFJY2qcVv2RBk=;\n\tb=U6hHlBrBoTT0lSTKdJqUc4kPLvFa8R2FhCelYIfEjD4l/BIeHnSFdqUxtKECQCyWRE\n\tDEg8EF5jxCi4vWX8XJSjc/nsYrD0E2MiZN8I5ooinjeNILDrJdYb6ECBcUNgOMaKuCIw\n\tE7kfLAGcZ6HuBb3MherrnBXomkA3xDfCn/auS8J5WwAmCxL9Y2ONdwzZSWLv2fd0cvu7\n\tCvZIoPBD2vNQbywMdpey0QeoOu9+IEXaclyetCxUHxkscFRHj9SlNuQD387hbVP473vq\n\tkmaV7tiLZrHL6AWc/DeRNvPwC+14hE3WW7l4JTc9gl8C34wsaqb7dg4Xl4srLxtNHhkx\n\tX+aA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Vujycd8EPvoebCgjNl2OyNBkTEe2zGIFJY2qcVv2RBk=;\n\tb=iWlHlgUTKaL8I559g5rVTpfZm5U0bbvdPO2BPkeQkGY2NsYQ7Il0t3wOfOTJigtOAg\n\ttBUdTs5DyZ2+vRIOqr/lT1djTliolkaSV3JDkDkfIel+I94k/iNVNqxUVg/PhW34vA3B\n\t5e2IsuazPa4Ow/KuB9DxVW70z207s1r9MJ+IqQRalqR9JeyWWwA+PS73eGulrNiBKn4y\n\tkDh8u4mUtQxZ/s1+cNNd/qRxfpb84DciWrsRNpnVh1YCmLVjc5Lmm5w75zXCVf1N3fDl\n\tk8P9qqQb1nzy3nGWBj4epytU4867YJPvDrXwe6+7EYj7SUvU39V6lWcukXa/nmi1ncgX\n\tLluQ==", "X-Gm-Message-State": "AOAM532uZqAK0LOOtVIsPdtsoeeJ62Cz70Vyt/tj7cbnQ8fSWgr72ido\n\txLhY8E3RgkvN9ZOWVNzJFpKbtmw29Zs=", "X-Google-Smtp-Source": "ABdhPJzYy9T/m2Hnh/9axzubc85MNseZn+F31JezUzycu265cF7a7z5SnzRrh6LMyKMAgTF0QGcdkw==", "X-Received": "by 2002:a63:be47:: with SMTP id g7mr20215120pgo.7.1595866922331; \n\tMon, 27 Jul 2020 09:22:02 -0700 (PDT)", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t<niklas.soderlund@ragnatech.se>", "Date": "Mon, 27 Jul 2020 21:51:43 +0530", "Message-Id": "<20200727162143.31317-4-kgupta@es.iitr.ac.in>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200727162143.31317-1-kgupta@es.iitr.ac.in>", "References": "<20200727162143.31317-1-kgupta@es.iitr.ac.in>", "Subject": "[libcamera-devel] [PATCH v4 3/3] libcamera: stream_option: use\n\tformat name to set cam/qcam format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace hex input for pixel formats with their format names, for input in\ncam and qcam.\nHence, remove the todo.\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n---\n src/cam/stream_options.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\nindex bd12c8f..4168e5d 100644\n--- a/src/cam/stream_options.cpp\n+++ b/src/cam/stream_options.cpp\n@@ -19,7 +19,7 @@ StreamKeyValueParser::StreamKeyValueParser()\n \t\t ArgumentRequired);\n \taddOption(\"height\", OptionInteger, \"Height in pixels\",\n \t\t ArgumentRequired);\n-\taddOption(\"pixelformat\", OptionInteger, \"Pixel format\",\n+\taddOption(\"pixelformat\", OptionString, \"Pixel format name\",\n \t\t ArgumentRequired);\n }\n \n@@ -95,9 +95,8 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,\n \t\t\tcfg.size.height = opts[\"height\"];\n \t\t}\n \n-\t\t/* \\todo Translate 4CC string to pixelformat with modifier. */\n \t\tif (opts.isSet(\"pixelformat\"))\n-\t\t\tcfg.pixelFormat = PixelFormat(opts[\"pixelformat\"]);\n+\t\t\tcfg.pixelFormat = PixelFormat::fromString(opts[\"pixelformat\"].toString());\n \t}\n \n \treturn 0;\n", "prefixes": [ "libcamera-devel", "v4", "3/3" ] }