Patch Detail
Show a patch.
GET /api/1.1/patches/8961/?format=api
{ "id": 8961, "url": "https://patchwork.libcamera.org/api/1.1/patches/8961/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8961/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724090744.508110-4-niklas.soderlund@ragnatech.se>", "date": "2020-07-24T09:07:43", "name": "[libcamera-devel,v2,3/4] android: camera_device: Remove scaler format information from Camera3Format", "commit_ref": "3312af649a28607f6718afdbd819aa5b70e11891", "pull_url": null, "state": "accepted", "archived": false, "hash": "7cc1cd8046631f71b2aa97199f6295821fc27a62", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8961/mbox/", "series": [ { "id": 1134, "url": "https://patchwork.libcamera.org/api/1.1/series/1134/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1134", "date": "2020-07-24T09:07:40", "name": "android: camera_device: Improve on format related tags", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1134/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8961/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8961/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 482C3BD879\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 09:07:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C8F161236;\n\tFri, 24 Jul 2020 11:07:59 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7851C611A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 11:07:55 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 28c373c3-cd8d-11ea-8fb8-005056917f90;\n\tFri, 24 Jul 2020 11:07:54 +0200 (CEST)" ], "X-Halon-ID": "28c373c3-cd8d-11ea-8fb8-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jul 2020 11:07:43 +0200", "Message-Id": "<20200724090744.508110-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200724090744.508110-1-niklas.soderlund@ragnatech.se>", "References": "<20200724090744.508110-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 3/4] android: camera_device: Remove\n\tscaler format information from Camera3Format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The scaler format information was only used for the\nANDROID_SCALER_AVAILABLE_FORMATS tag which is deprecated and removed. As\nit has no other users remove it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 96dd8d5a99082966..d9fdaf44b2803399 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -42,13 +42,10 @@ const std::vector<Size> camera3Resolutions = {\n * \\brief Data associated with an Android format identifier\n * \\var libcameraFormats List of libcamera pixel formats compatible with the\n * Android format\n- * \\var scalerFormat The format identifier to be reported to the android\n- * framework through the static format configuration map\n * \\var name The human-readable representation of the Android format code\n */\n struct Camera3Format {\n \tstd::vector<PixelFormat> libcameraFormats;\n-\tcamera_metadata_enum_android_scaler_available_formats_t scalerFormat;\n \tconst char *name;\n };\n \n@@ -60,13 +57,11 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {\n \t{\n \t\tHAL_PIXEL_FORMAT_BLOB, {\n \t\t\t{ formats::MJPEG },\n-\t\t\tANDROID_SCALER_AVAILABLE_FORMATS_BLOB,\n \t\t\t\"BLOB\"\n \t\t}\n \t}, {\n \t\tHAL_PIXEL_FORMAT_YCbCr_420_888, {\n \t\t\t{ formats::NV12, formats::NV21 },\n-\t\t\tANDROID_SCALER_AVAILABLE_FORMATS_YCbCr_420_888,\n \t\t\t\"YCbCr_420_888\"\n \t\t}\n \t}, {\n@@ -76,7 +71,6 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {\n \t\t */\n \t\tHAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED, {\n \t\t\t{ formats::NV12, formats::NV21 },\n-\t\t\tANDROID_SCALER_AVAILABLE_FORMATS_IMPLEMENTATION_DEFINED,\n \t\t\t\"IMPLEMENTATION_DEFINED\"\n \t\t}\n \t},\n", "prefixes": [ "libcamera-devel", "v2", "3/4" ] }