Patch Detail
Show a patch.
GET /api/1.1/patches/8942/?format=api
{ "id": 8942, "url": "https://patchwork.libcamera.org/api/1.1/patches/8942/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8942/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200723173942.98182-5-niklas.soderlund@ragnatech.se>", "date": "2020-07-23T17:39:42", "name": "[libcamera-devel,4/4] android: camera_device: Add ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9213e36a3bf0bab61b04263ad9e626c35c04e936", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8942/mbox/", "series": [ { "id": 1130, "url": "https://patchwork.libcamera.org/api/1.1/series/1130/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1130", "date": "2020-07-23T17:39:38", "name": "android: camera_device: Improve on format related tags", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1130/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8942/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8942/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7A4DBD879\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jul 2020 17:40:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 791BE611B2;\n\tThu, 23 Jul 2020 19:40:53 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 814EB6114F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jul 2020 19:40:50 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid a54ece28-cd0b-11ea-933e-005056917a89;\n\tThu, 23 Jul 2020 19:40:49 +0200 (CEST)" ], "X-Halon-ID": "a54ece28-cd0b-11ea-933e-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Jul 2020 19:39:42 +0200", "Message-Id": "<20200723173942.98182-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200723173942.98182-1-niklas.soderlund@ragnatech.se>", "References": "<20200723173942.98182-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Define the ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS to zero to inform users\nthe HAL does not support any reprocessing.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/android/camera_device.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d9fdaf44b2803399..0e9fc216d2b54a1a 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -370,8 +370,8 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n \t * \\todo Keep this in sync with the actual number of entries.\n \t * Currently: 50 entries, 647 bytes of static metadata\n \t */\n-\tuint32_t numEntries = 49;\n-\tuint32_t byteSize = 647;\n+\tuint32_t numEntries = 50;\n+\tuint32_t byteSize = 648;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -699,6 +699,11 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n \t\t\t\t &maxPipelineDepth, 1);\n \n+\t/* LIMITED does not support reprocessing. */\n+\tuint8_t maxNumInputStreams = 0;\n+\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n+\t\t\t\t &maxNumInputStreams, 1);\n+\n \tstd::vector<uint8_t> availableCapabilities = {\n \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n \t};\n@@ -752,6 +757,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n+\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n \t};\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n", "prefixes": [ "libcamera-devel", "4/4" ] }