Patch Detail
Show a patch.
GET /api/1.1/patches/8799/?format=api
{ "id": 8799, "url": "https://patchwork.libcamera.org/api/1.1/patches/8799/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8799/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200714233325.14951-1-laurent.pinchart@ideasonboard.com>", "date": "2020-07-14T23:33:25", "name": "[libcamera-devel] libcamera: pipeline: simple: Use std::make_tuple()", "commit_ref": "ed1b290aab18cfd9bf97a4e85f79b4d65d1906ca", "pull_url": null, "state": "accepted", "archived": false, "hash": "e80994d2fd206ed68b8f0739666e3aede0b6913f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8799/mbox/", "series": [ { "id": 1106, "url": "https://patchwork.libcamera.org/api/1.1/series/1106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1106", "date": "2020-07-14T23:33:25", "name": "[libcamera-devel] libcamera: pipeline: simple: Use std::make_tuple()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8799/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8799/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4FCDBD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jul 2020 23:33:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 699AD6091A;\n\tWed, 15 Jul 2020 01:33:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E78B60745\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Jul 2020 01:33:35 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1471371D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Jul 2020 01:33:35 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A+gL7fsE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594769615;\n\tbh=FTYUw724r9q63EcbnJUAlCikQ2XAK1vdZjRAeClqEqE=;\n\th=From:To:Subject:Date:From;\n\tb=A+gL7fsEIq5DF3kNnYvpugxRZGXna3gId7gHOP+5U9dGkwx8DqhSrfBbPKMa9LfYG\n\to1E1IMlepDrIFjnBIXIA7VV+w5M8xASvi7HyX1nDp168OCe8EuKgn8Fec6yfY7RO0W\n\ty5xsRZV854o6bEqawcLSkDPzb0mo00HwI68p7spE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 15 Jul 2020 02:33:25 +0300", "Message-Id": "<20200714233325.14951-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Prior to N4387 ([1]), the std::tuple::tuple(const Types&...) constructor\nwas unconditionally explicit. gcc 5 doesn't implement N4387, leading to\na compilation error in the simple pipeline handler. Use\nstd::make_tuple() to fix it.\n\n[1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4387.html\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/converter.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex dc7c046329f1..75fb297ebd58 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -271,9 +271,9 @@ SimpleConverter::strideAndFrameSize(const Size &size,\n \n \tint ret = m2m_->capture()->tryFormat(&format);\n \tif (ret < 0)\n-\t\treturn { 0, 0 };\n+\t\treturn std::make_tuple(0, 0);\n \n-\treturn { format.planes[0].bpl, format.planes[0].size };\n+\treturn std::make_tuple(format.planes[0].bpl, format.planes[0].size);\n }\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel" ] }