Patch Detail
Show a patch.
GET /api/1.1/patches/8779/?format=api
{ "id": 8779, "url": "https://patchwork.libcamera.org/api/1.1/patches/8779/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8779/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200714104212.48683-5-jacopo@jmondi.org>", "date": "2020-07-14T10:41:56", "name": "[libcamera-devel,04/20] libcamera: geometry: Add isNull() function to Rectangle class", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2462938c031f1730fa956d631435cd7e1a0b54e3", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8779/mbox/", "series": [ { "id": 1104, "url": "https://patchwork.libcamera.org/api/1.1/series/1104/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1104", "date": "2020-07-14T10:41:52", "name": "libcamera: ipu3: Rework pipe configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1104/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8779/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8779/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BB33BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jul 2020 10:38:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2930960890;\n\tTue, 14 Jul 2020 12:38:52 +0200 (CEST)", "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 758B860745\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jul 2020 12:38:50 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id DACCA24000F;\n\tTue, 14 Jul 2020 10:38:49 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 14 Jul 2020 12:41:56 +0200", "Message-Id": "<20200714104212.48683-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200714104212.48683-1-jacopo@jmondi.org>", "References": "<20200714104212.48683-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 04/20] libcamera: geometry: Add isNull()\n\tfunction to Rectangle class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It's common for code to check if a rectangle is null. Add a helper function\nto do so and test the function in test/geometry.cpp\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/geometry.h | 1 +\n src/libcamera/geometry.cpp | 6 ++++++\n test/geometry.cpp | 6 ++++++\n 3 files changed, 13 insertions(+)", "diff": "diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex d217cfd50c86..98a919eb01f1 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -19,6 +19,7 @@ struct Rectangle {\n \tunsigned int width;\n \tunsigned int height;\n \n+\tbool isNull() const { return !width && !height; }\n \tconst std::string toString() const;\n };\n \ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 4594f9ff435f..f79f769bf88e 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -49,6 +49,12 @@ namespace libcamera {\n * \\brief The distance between the top and bottom sides\n */\n \n+/**\n+ * \\fn bool Rectangle::isNull() const\n+ * \\brief Check if the rectangle is null\n+ * \\return True if both the width and height are 0, or false otherwise\n+ */\n+\n /**\n * \\brief Assemble and return a string describing the rectangle\n * \\return A string describing the Rectangle\ndiff --git a/test/geometry.cpp b/test/geometry.cpp\nindex fd0132c03b02..72d938b40e54 100644\n--- a/test/geometry.cpp\n+++ b/test/geometry.cpp\n@@ -36,6 +36,12 @@ protected:\n \n \tint run()\n \t{\n+\t\tRectangle r{};\n+\t\tif (!r.isNull()) {\n+\t\t\tcout << \"Null rectangle incorrectly reported as not null\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\tif (!Size().isNull() || !Size(0, 0).isNull()) {\n \t\t\tcout << \"Null size incorrectly reported as not null\" << endl;\n \t\t\treturn TestFail;\n", "prefixes": [ "libcamera-devel", "04/20" ] }