Patch Detail
Show a patch.
GET /api/1.1/patches/8744/?format=api
{ "id": 8744, "url": "https://patchwork.libcamera.org/api/1.1/patches/8744/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8744/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200711054555.495244-2-paul.elder@ideasonboard.com>", "date": "2020-07-11T05:45:55", "name": "[libcamera-devel,v2,2/2] tests: v4l2_compat: Check v4l2-compliance and v4l2-ctl versions", "commit_ref": "74c8b508338ccdd0780aa1e067a1e8fcb9ee326b", "pull_url": null, "state": "accepted", "archived": false, "hash": "db35b02ecf50737837a666369a5fa449d9cfabf8", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8744/mbox/", "series": [ { "id": 1097, "url": "https://patchwork.libcamera.org/api/1.1/series/1097/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1097", "date": "2020-07-11T05:45:54", "name": "[libcamera-devel,v2,1/2] tests: v4l2_compat: Prettify failure output", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1097/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8744/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8744/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C509FBD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 11 Jul 2020 05:46:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E55860553;\n\tSat, 11 Jul 2020 07:46:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDE806054E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 Jul 2020 07:46:10 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0507D2FD;\n\tSat, 11 Jul 2020 07:46:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aFhINSe8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594446370;\n\tbh=M9FDyUefJPqH2kTAEvEuIO46D+x5nddX4WcUn43ZHJ4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aFhINSe8hsYMGbtU0iwBlHu0K2Ps/rXQGmszFMX4FHAnV8hR57ZmmrdDaEtxkCtrJ\n\tGaU1tYFRPgzvXTLz0Sx1vobAuwMNdT1si2XiY1in3O91Cyu31xT02JNH0Lo5j0rLAr\n\tk2f9nIAfRF+3+qJEI/b0dUKorRLPtqg9BnrEqnzE=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 11 Jul 2020 14:45:55 +0900", "Message-Id": "<20200711054555.495244-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200711054555.495244-1-paul.elder@ideasonboard.com>", "References": "<20200711054555.495244-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/2] tests: v4l2_compat: Check\n\tv4l2-compliance and v4l2-ctl versions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "v4l2-compliance and v4l2-ctl with version 1.20 and before will fail with\nv4l2-compat. Check the versions of v4l2-compliance and v4l2-ctl before\ncontinuing.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v2:\n- actually check the version number\n---\n test/v4l2_compat/v4l2_compat_test.py | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\nindex 8aca222..b054fe6 100755\n--- a/test/v4l2_compat/v4l2_compat_test.py\n+++ b/test/v4l2_compat/v4l2_compat_test.py\n@@ -9,12 +9,15 @@\n import argparse\n import glob\n import os\n+from packaging import version\n import re\n import shutil\n import signal\n import subprocess\n import sys\n \n+MIN_V4L_UTILS_VERSION = version.parse(\"1.21.0\")\n+\n TestPass = 0\n TestFail = -1\n TestSkip = 77\n@@ -90,11 +93,21 @@ def main(argv):\n print('v4l2-compliance is not available')\n return TestSkip\n \n+ ret, out = run_with_stdout(v4l2_compliance, '--version')\n+ if (ret != 0 or version.parse(out[-2].split()[-1]) < MIN_V4L_UTILS_VERSION):\n+ print('v4l2-compliance version >= 1.21.0 required')\n+ return TestSkip\n+\n v4l2_ctl = shutil.which('v4l2-ctl')\n if v4l2_ctl is None:\n print('v4l2-ctl is not available')\n return TestSkip\n \n+ ret, out = run_with_stdout(v4l2_ctl, '--version')\n+ if (ret != 0 or version.parse(out[-2].split()[-1]) < MIN_V4L_UTILS_VERSION):\n+ print('v4l2-ctl version >= 1.21.0 required')\n+ return TestSkip\n+\n dev_nodes = glob.glob('/dev/video*')\n if len(dev_nodes) == 0:\n print('no video nodes available to test with')\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }