Patch Detail
Show a patch.
GET /api/1.1/patches/8702/?format=api
{ "id": 8702, "url": "https://patchwork.libcamera.org/api/1.1/patches/8702/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8702/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200709084128.5316-12-jacopo@jmondi.org>", "date": "2020-07-09T08:41:19", "name": "[libcamera-devel,v2,11/20] libcamera: ipu3: Adjust full frame picture to 32 pixels", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f2adc797448601345302306f935db3b6294d198d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/8702/mbox/", "series": [ { "id": 1091, "url": "https://patchwork.libcamera.org/api/1.1/series/1091/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1091", "date": "2020-07-09T08:41:08", "name": "libcamera: ipu3: Rework configuration", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1091/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8702/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8702/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63017BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Jul 2020 08:38:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3892B611B7;\n\tThu, 9 Jul 2020 10:38:17 +0200 (CEST)", "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94DD6611B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Jul 2020 10:38:14 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 0C8F010000B;\n\tThu, 9 Jul 2020 08:38:13 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Jul 2020 10:41:19 +0200", "Message-Id": "<20200709084128.5316-12-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200709084128.5316-1-jacopo@jmondi.org>", "References": "<20200709084128.5316-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 11/20] libcamera: ipu3: Adjust full\n\tframe picture to 32 pixels", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To respect the same constraint introduced in validate() that the maximum\nImgU output size shall be at least 32 pixels smaller than the full frame\nsize, adjust the sizes assigned to the StillCapture role in\ngenerateConfiguration().\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 18f4a02cc270..d07f1a7b5ae8 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -320,10 +320,14 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n \t\t\t/*\n \t\t\t * Use the sensor resolution aligned to the ImgU\n \t\t\t * output constraints.\n+\t\t\t *\n+\t\t\t * \\todo Give 32 pixels from the sensor frame size\n+\t\t\t * for the IF and BDS rectangles to scale. See\n+\t\t\t * the todo note for te same operation in validate().\n \t\t\t */\n-\t\t\tsize.width = std::min(sensorResolution.width,\n+\t\t\tsize.width = std::min(sensorResolution.width - 32,\n \t\t\t\t\t IPU3_OUTPUT_MAX_WIDTH);\n-\t\t\tsize.height = std::min(sensorResolution.height,\n+\t\t\tsize.height = std::min(sensorResolution.height - 32,\n \t\t\t\t\t IPU3_OUTPUT_MAX_HEIGHT);\n \t\t\tsize.width &= ~IPU3_OUTPUT_WIDTH_ALIGN;\n \t\t\tsize.height &= ~IPU3_OUTPUT_HEIGHT_ALIGN;\n", "prefixes": [ "libcamera-devel", "v2", "11/20" ] }