Patch Detail
Show a patch.
GET /api/1.1/patches/8689/?format=api
{ "id": 8689, "url": "https://patchwork.libcamera.org/api/1.1/patches/8689/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8689/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200708134417.67747-21-paul.elder@ideasonboard.com>", "date": "2020-07-08T13:44:16", "name": "[libcamera-devel,v4,20/21] libcamera: StreamConfiguration: Update stride documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2b598096b81eb0e63167c41901129ae8ec4c9590", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8689/mbox/", "series": [ { "id": 1090, "url": "https://patchwork.libcamera.org/api/1.1/series/1090/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1090", "date": "2020-07-08T13:43:56", "name": "Clean up formats in v4l2-compat and pipeline handlers", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1090/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8689/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8689/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B595BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jul 2020 13:45:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43FB66114B;\n\tWed, 8 Jul 2020 15:45:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54D8A6112A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jul 2020 15:45:12 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84F6751B;\n\tWed, 8 Jul 2020 15:45:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"El9dglL9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594215912;\n\tbh=iUzgDUIl6wx+0Ba/u/OJHSInd7u/9mYQOHVAkRmnPaQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=El9dglL9NHbaScqS7pA13Xk6CupFeOoPP34/QfVJibNfkVZVlA738DcVJj4NfE2VR\n\tzDXGPUgd8JjjxZQbNj1tru++TLI/+NL5Flh05mTUddIIWNCI5zc24BS8Ev3IPg5FcF\n\txeWaUk0ONUzLmO7Q0/236+QzTfrp8lswwUU7Arp8=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 8 Jul 2020 22:44:16 +0900", "Message-Id": "<20200708134417.67747-21-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200708134417.67747-1-paul.elder@ideasonboard.com>", "References": "<20200708134417.67747-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 20/21] libcamera: StreamConfiguration:\n\tUpdate stride documentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that all the pipeline handlers fill in the stride information at\nvalidation time, update the documentation accordingly.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v4\n\nNew in v3\n---\n src/libcamera/stream.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 6d6e279..d5da834 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -309,11 +309,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n *\n * The stride value reports the number of bytes between the beginning of\n * successive lines in an image buffer for this stream. The value is\n- * valid after successfully configuring the camera with this\n- * configuration with a call to Camera::Configure().\n- *\n- * \\todo Update this value when configuration is validated instead of when\n- * the camera is configured.\n+ * valid after successfully validating the configuration with a call to\n+ * CameraConfiguration::validate().\n */\n \n /**\n", "prefixes": [ "libcamera-devel", "v4", "20/21" ] }