Patch Detail
Show a patch.
GET /api/1.1/patches/8652/?format=api
{ "id": 8652, "url": "https://patchwork.libcamera.org/api/1.1/patches/8652/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8652/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200706153808.2340919-2-kieran.bingham@ideasonboard.com>", "date": "2020-07-06T15:38:01", "name": "[libcamera-devel,v4,1/8] libcamera: camera: Allow unspecified roles for generateConfiguration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f9d6e2dd1da6222c720b1d00226f62121ba67301", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8652/mbox/", "series": [ { "id": 1088, "url": "https://patchwork.libcamera.org/api/1.1/series/1088/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1088", "date": "2020-07-06T15:38:00", "name": "android: Multi-stream support", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1088/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8652/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8652/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E253BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2020 15:38:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CB6360E05;\n\tMon, 6 Jul 2020 17:38:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2D28603AA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2020 17:38:12 +0200 (CEST)", "from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 600DEAC6;\n\tMon, 6 Jul 2020 17:38:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eLE2zV5H\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594049892;\n\tbh=Ryw+qOixyBuEMieEDC/DJyE24i6nMiEbmEfegzYOkVg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eLE2zV5HTN70rdMyGFFs3DsvjuGeO/zyy02PKmP5SWxXlS8Judh6M2jbe9WE1jvjj\n\tFtJYmjdGwFngqrUANqC3tzll6OBF39Krx54wv5E54v1veqw2Jyl6z+4OOqbMQ7Y+bN\n\t+HFRvSTOUFlDcNUAfJPrCF84notXT4W2vFIfEPGQ=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 6 Jul 2020 16:38:01 +0100", "Message-Id": "<20200706153808.2340919-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200706153808.2340919-1-kieran.bingham@ideasonboard.com>", "References": "<20200706153808.2340919-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 1/8] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Providing an empty set of roles is permitted to generate an empty\nconfiguration from the pipeline handlers.\n\nOverload the generateConfiguration() function such that not specifying a\nroles parameter will use an empty set, and return an empty\nconfiguration.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/camera.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 9c0e58f7864b..4d1a4a9f52ec 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -89,7 +89,7 @@ public:\n \tconst ControlList &properties();\n \n \tconst std::set<Stream *> &streams() const;\n-\tstd::unique_ptr<CameraConfiguration> generateConfiguration(const StreamRoles &roles);\n+\tstd::unique_ptr<CameraConfiguration> generateConfiguration(const StreamRoles &roles = {});\n \tint configure(CameraConfiguration *config);\n \n \tRequest *createRequest(uint64_t cookie = 0);\n", "prefixes": [ "libcamera-devel", "v4", "1/8" ] }