Patch Detail
Show a patch.
GET /api/1.1/patches/8609/?format=api
{ "id": 8609, "url": "https://patchwork.libcamera.org/api/1.1/patches/8609/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8609/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200704005227.21782-6-laurent.pinchart@ideasonboard.com>", "date": "2020-07-04T00:52:20", "name": "[libcamera-devel,v2,05/12] libcamera: pipeline: raspberrypi: Constify parameter to StaggeredCtrl::set()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "69159293bbd594c2b8d8d2ccbbf2fa6955388cda", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8609/mbox/", "series": [ { "id": 1081, "url": "https://patchwork.libcamera.org/api/1.1/series/1081/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1081", "date": "2020-07-04T00:52:15", "name": "Support passing custom data to IPA configure()", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1081/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8609/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8609/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB0A8C2E69\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jul 2020 00:52:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B2E960D57;\n\tSat, 4 Jul 2020 02:52:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6DB460D66\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jul 2020 02:52:38 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E5EB29E;\n\tSat, 4 Jul 2020 02:52:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jtj6Nn5r\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593823958;\n\tbh=qbP3Ynsxr47ZYu9MyxvHqqqNPrmmQsz7MkKRtiJD8O4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jtj6Nn5roIhQF/AbJPH1NKTAK3UaJ1qgDiQKLJoTFadk0uNltN2qWBEKSHzjlJSdZ\n\tJXqsp6c7RE5DOkRU5hRpkeZoZe7/2dWx5qjtRrJhfgsa/qfbPBwoWAVSTKl+l2zBED\n\tQsrFCIk0yWeXjoDdh7OmvuNoOXV/vOM48+e2CoJs=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jul 2020 03:52:20 +0300", "Message-Id": "<20200704005227.21782-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>", "References": "<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 05/12] libcamera: pipeline:\n\traspberrypi: Constify parameter to StaggeredCtrl::set()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The controls parameter of StaggeredCtrl::set(), passed by reference, is\nnot modified by the function. Make it const.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\nindex 416cb9467147..0572acc93d63 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n@@ -91,7 +91,7 @@ bool StaggeredCtrl::set(std::initializer_list<std::pair<const uint32_t, int32_t>\n \treturn true;\n }\n \n-bool StaggeredCtrl::set(ControlList &controls)\n+bool StaggeredCtrl::set(const ControlList &controls)\n {\n \tstd::lock_guard<std::mutex> lock(lock_);\n \ndiff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\nindex 98994a6177e1..382fa31a6853 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.h\n@@ -41,7 +41,7 @@ public:\n \n \tbool set(uint32_t ctrl, int32_t value);\n \tbool set(std::initializer_list<std::pair<const uint32_t, int32_t>> ctrlList);\n-\tbool set(ControlList &controls);\n+\tbool set(const ControlList &controls);\n \n \tint write();\n \n", "prefixes": [ "libcamera-devel", "v2", "05/12" ] }