Patch Detail
Show a patch.
GET /api/1.1/patches/8608/?format=api
{ "id": 8608, "url": "https://patchwork.libcamera.org/api/1.1/patches/8608/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8608/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200704005227.21782-5-laurent.pinchart@ideasonboard.com>", "date": "2020-07-04T00:52:19", "name": "[libcamera-devel,v2,04/12] libcamera: pipeline: raspberrypi: Drop unused local variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53eac7b9e83fc5200bf065af8a5a88482464a0bf", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8608/mbox/", "series": [ { "id": 1081, "url": "https://patchwork.libcamera.org/api/1.1/series/1081/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1081", "date": "2020-07-04T00:52:15", "name": "Support passing custom data to IPA configure()", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1081/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8608/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8608/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61B78BE905\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jul 2020 00:52:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22EFD60DD1;\n\tSat, 4 Jul 2020 02:52:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FDA5603BB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jul 2020 02:52:38 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C184F51B;\n\tSat, 4 Jul 2020 02:52:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NCp6SMuQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593823958;\n\tbh=vY2MV8vzspMBj7psJvwf3IL25t5Gw12nrd5H7AULwa4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NCp6SMuQq2fbbfmTyv+DFSu51d0298NnHeJgO7xDYPVElmyNpFUfysYOOvEsIVu65\n\tqAPaOrPsMI1CmYu1NMmXdHI4jmlhpeQpeBFzfqJezQv2NJ7QRWmLnmUQDvoOdkvLJ0\n\tBiVzG12Do1kJ5IAvDf4w6etKGZbmjqrfPMzGfDIM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jul 2020 03:52:19 +0300", "Message-Id": "<20200704005227.21782-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>", "References": "<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 04/12] libcamera: pipeline:\n\traspberrypi: Drop unused local variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The controls variable in PipelineHandlerRPi::start() is unused. Drop it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ab4b915156e1..db0b20135318 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -787,7 +787,6 @@ int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream,\n int PipelineHandlerRPi::start(Camera *camera)\n {\n \tRPiCameraData *data = cameraData(camera);\n-\tControlList controls(data->sensor_->controls());\n \tint ret;\n \n \t/* Allocate buffers for internal pipeline usage. */\n", "prefixes": [ "libcamera-devel", "v2", "04/12" ] }