Patch Detail
Show a patch.
GET /api/1.1/patches/8588/?format=api
{ "id": 8588, "url": "https://patchwork.libcamera.org/api/1.1/patches/8588/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8588/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200703123919.2223048-9-kieran.bingham@ideasonboard.com>", "date": "2020-07-03T12:39:19", "name": "[libcamera-devel,v3,8/8] android: camera_device: Remove single buffer restriction.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ddb42c8e33ce431d10619f4e3887fd27f8c3a64b", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8588/mbox/", "series": [ { "id": 1077, "url": "https://patchwork.libcamera.org/api/1.1/series/1077/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1077", "date": "2020-07-03T12:39:11", "name": "android: Multi-stream support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1077/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8588/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8588/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B77CBFFE2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Jul 2020 12:39:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1605A60CDE;\n\tFri, 3 Jul 2020 14:39:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31A3B60CB3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Jul 2020 14:39:27 +0200 (CEST)", "from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD361296;\n\tFri, 3 Jul 2020 14:39:26 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NU07SikG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593779966;\n\tbh=4bbliLntF8jQWM6iojhcAED6BckLBxrkdLV+WRKTcE8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NU07SikGLZFkLya5ksOqjQ4R78aHm+TzTCX5D3Hj1jYcjcRZP925FytCXPGaMpKrO\n\t/2wO7kpUPAeMlmpNVL+oyP/ul1opPihAQhrMpGZSC7Qy8pUuNNoFqNq3MyBH073dut\n\t8l63fq+EWXHj62DaGiTUpJ0Mcw48eByOAKID67S4=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 3 Jul 2020 13:39:19 +0100", "Message-Id": "<20200703123919.2223048-9-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>", "References": "<20200703123919.2223048-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 8/8] android: camera_device: Remove\n\tsingle buffer restriction.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A capture request is no longer limited to a single output buffer.\nRemove the limitation, but (for now) keep the check to ensure that\nat least one buffer is always provided.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_device.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3d21e59af258..1f85e7e535f5 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1050,9 +1050,8 @@ FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer\n \n int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n {\n-\tif (camera3Request->num_output_buffers != 1) {\n-\t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n-\t\t\t\t<< camera3Request->num_output_buffers;\n+\tif (!camera3Request->num_output_buffers) {\n+\t\tLOG(HAL, Error) << \"No output buffers provided\";\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "libcamera-devel", "v3", "8/8" ] }