Patch Detail
Show a patch.
GET /api/1.1/patches/8556/?format=api
{ "id": 8556, "url": "https://patchwork.libcamera.org/api/1.1/patches/8556/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8556/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200702213654.2129054-2-kieran.bingham@ideasonboard.com>", "date": "2020-07-02T21:36:46", "name": "[libcamera-devel,v2,1/9] libcamera: camera: Allow unspecified roles for generateConfiguration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f9d6e2dd1da6222c720b1d00226f62121ba67301", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8556/mbox/", "series": [ { "id": 1073, "url": "https://patchwork.libcamera.org/api/1.1/series/1073/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1073", "date": "2020-07-02T21:36:45", "name": "android: Multi-stream support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1073/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8556/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8556/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9FDBBE905\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Jul 2020 21:37:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CF2C60C56;\n\tThu, 2 Jul 2020 23:37:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D87E603B4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Jul 2020 23:37:03 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1B5CA2D;\n\tThu, 2 Jul 2020 23:37:02 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g1a+7qly\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593725822;\n\tbh=ZfLLGz9HxSw+6HxX7yndm4O7hI1oXiMwIW6km/OxJ6A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g1a+7qlyDJ3DZhfiJoBQqJeDdLTjt2x/s1rbY/F9LqDXfdwpQ/MGstQpU2viFBeTj\n\t0l15v6QmluH4ApXL6H36FGVXy1Sbcdigm6bOj5c716PDuF6WgndsglQbJOw0gtrcSP\n\tUnyFPs6rFROw0GfKgEqxFPEfIiBM6h18xcxmlads=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 2 Jul 2020 22:36:46 +0100", "Message-Id": "<20200702213654.2129054-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>", "References": "<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/9] libcamera: camera: Allow\n\tunspecified roles for generateConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Providing an empty set of roles is permitted to generate an empty\nconfiguration from the pipeline handlers.\n\nOverload the generateConfiguration() function such that not specifying a\nroles parameter will use an empty set, and return an empty\nconfiguration.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/camera.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 9c0e58f7864b..4d1a4a9f52ec 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -89,7 +89,7 @@ public:\n \tconst ControlList &properties();\n \n \tconst std::set<Stream *> &streams() const;\n-\tstd::unique_ptr<CameraConfiguration> generateConfiguration(const StreamRoles &roles);\n+\tstd::unique_ptr<CameraConfiguration> generateConfiguration(const StreamRoles &roles = {});\n \tint configure(CameraConfiguration *config);\n \n \tRequest *createRequest(uint64_t cookie = 0);\n", "prefixes": [ "libcamera-devel", "v2", "1/9" ] }