Patch Detail
Show a patch.
GET /api/1.1/patches/8538/?format=api
{ "id": 8538, "url": "https://patchwork.libcamera.org/api/1.1/patches/8538/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8538/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200701123036.51922-12-jacopo@jmondi.org>", "date": "2020-07-01T12:30:32", "name": "[libcamera-devel,11/15] libcamera: geometry: Add isNull() function to Rectangle class", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c9da59a911a2d99c6074630bb585276a56fed7a6", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8538/mbox/", "series": [ { "id": 1066, "url": "https://patchwork.libcamera.org/api/1.1/series/1066/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1066", "date": "2020-07-01T12:30:21", "name": "libcamera: ipu3: Rework streams configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1066/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8538/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8538/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50C5BBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Jul 2020 12:27:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 223D560CBE;\n\tWed, 1 Jul 2020 14:27:27 +0200 (CEST)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8909960CC2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Jul 2020 14:27:25 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 2813C1C0003;\n\tWed, 1 Jul 2020 12:27:24 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 1 Jul 2020 14:30:32 +0200", "Message-Id": "<20200701123036.51922-12-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200701123036.51922-1-jacopo@jmondi.org>", "References": "<20200701123036.51922-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 11/15] libcamera: geometry: Add isNull()\n\tfunction to Rectangle class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It's common for code to check if a rectangle is null. Add a helper function\nto do so.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/geometry.h | 1 +\n src/libcamera/geometry.cpp | 6 ++++++\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex 7d4b8bcfe3d8..44561d9cc5a4 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -18,6 +18,7 @@ struct Rectangle {\n \tunsigned int width;\n \tunsigned int height;\n \n+\tbool isNull() const { return !width && !height; }\n \tconst std::string toString() const;\n };\n \ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 24c44fb43acf..af29ed1119fe 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -49,6 +49,12 @@ namespace libcamera {\n * \\brief The distance between the top and bottom sides\n */\n \n+/**\n+ * \\fn bool Rectangle::isNull() const\n+ * \\brief Check if the rectangle is null\n+ * \\return True if both the width and height are 0, or false otherwise\n+ */\n+\n /**\n * \\brief Assemble and return a string describing the rectangle\n * \\return A string describing the Rectangle\n", "prefixes": [ "libcamera-devel", "11/15" ] }