Patch Detail
Show a patch.
GET /api/1.1/patches/8515/?format=api
{ "id": 8515, "url": "https://patchwork.libcamera.org/api/1.1/patches/8515/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8515/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200630124307.83848-1-niklas.soderlund@ragnatech.se>", "date": "2020-06-30T12:43:07", "name": "[libcamera-devel,v2] libcamera: raspberrypi: Document vc_sm_cma pointer sharing with IPA", "commit_ref": "8e137b08194ea73c63832750af5ad2930688aa8a", "pull_url": null, "state": "accepted", "archived": false, "hash": "acf8e87af22c1f107d9b6ccd09b370c65d3625d5", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8515/mbox/", "series": [ { "id": 1061, "url": "https://patchwork.libcamera.org/api/1.1/series/1061/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1061", "date": "2020-06-30T12:43:07", "name": "[libcamera-devel,v2] libcamera: raspberrypi: Document vc_sm_cma pointer sharing with IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1061/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8515/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8515/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1C24BFFE2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Jun 2020 12:43:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A93460C56;\n\tTue, 30 Jun 2020 14:43:23 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F03D603B4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Jun 2020 14:43:22 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 4578575b-bacf-11ea-8fb8-005056917f90;\n\tTue, 30 Jun 2020 14:43:21 +0200 (CEST)" ], "X-Halon-ID": "4578575b-bacf-11ea-8fb8-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Jun 2020 14:43:07 +0200", "Message-Id": "<20200630124307.83848-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2] libcamera: raspberrypi: Document\n\tvc_sm_cma pointer sharing with IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Sharing a pointer with the IPA is fragile as it will not work with all\nIPC mechanisms. Document that it's a temporary workaround that should be\nreworked.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n* Changes since v1\n- Make comment less alarmist.\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 9d887b706c3f9670..f4966f8628eedbdd 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1014,6 +1014,11 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)\n \t\t/*\n \t\t * The vcsm allocation will always be in the memory region\n \t\t * < 32-bits to allow Videocore to access the memory.\n+\t\t *\n+\t\t * \\todo Sending a pointer to the IPA is a workaround for\n+\t\t * vc_sm_cma not yet supporting dmabuf. This will not work with\n+\t\t * IPA module isolation and should be reworked when vc_sma_cma\n+\t\t * will permit.\n \t\t */\n \t\tIPAOperationData op;\n \t\top.operation = RPI_IPA_EVENT_LS_TABLE_ALLOCATION;\n", "prefixes": [ "libcamera-devel", "v2" ] }