Patch Detail
Show a patch.
GET /api/1.1/patches/8479/?format=api
{ "id": 8479, "url": "https://patchwork.libcamera.org/api/1.1/patches/8479/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8479/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200628161723.30625-3-jacopo@jmondi.org>", "date": "2020-06-28T16:17:22", "name": "[libcamera-devel,2/3] libcamera: raspberrypi: Fail on unsupported stream role", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "62aeec1c2ac66fc98de12aa75384237552b4bf3c", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8479/mbox/", "series": [ { "id": 1052, "url": "https://patchwork.libcamera.org/api/1.1/series/1052/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1052", "date": "2020-06-28T16:17:20", "name": "libcamera: pipeline handlers: Fail if roles are not supported", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1052/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8479/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8479/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19D56C2E66\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Jun 2020 16:14:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4700960AF6;\n\tSun, 28 Jun 2020 18:14:00 +0200 (CEST)", "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3F58609C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Jun 2020 18:13:58 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 4315810000B;\n\tSun, 28 Jun 2020 16:13:58 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 28 Jun 2020 18:17:22 +0200", "Message-Id": "<20200628161723.30625-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200628161723.30625-1-jacopo@jmondi.org>", "References": "<20200628161723.30625-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: raspberrypi: Fail on\n\tunsupported stream role", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When an unsupported stream roles is requested to\ngenerateConfiguration(), the function shall fail instead of simply\nignoring the request.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex d1338b640e3c..aa7b7eb93aab 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -568,7 +568,8 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n \t\tdefault:\n \t\t\tLOG(RPI, Error) << \"Requested stream role not supported: \"\n \t\t\t\t\t<< role;\n-\t\t\tbreak;\n+\t\t\tdelete config;\n+\t\t\treturn nullptr;\n \t\t}\n \n \t\tif (rawCount > 1 || outCount > 2) {\n", "prefixes": [ "libcamera-devel", "2/3" ] }