Patch Detail
Show a patch.
GET /api/1.1/patches/841/?format=api
{ "id": 841, "url": "https://patchwork.libcamera.org/api/1.1/patches/841/?format=api", "web_url": "https://patchwork.libcamera.org/patch/841/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190402005406.25097-5-niklas.soderlund@ragnatech.se>", "date": "2019-04-02T00:54:06", "name": "[libcamera-devel,4/4] cam: Allow cameras with more then one stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0aa16e0bd5013d402949b1ad4569fcc35095a833", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": { "id": 16, "url": "https://patchwork.libcamera.org/api/1.1/users/16/?format=api", "username": "neg", "first_name": "Niklas", "last_name": "Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "mbox": "https://patchwork.libcamera.org/patch/841/mbox/", "series": [ { "id": 228, "url": "https://patchwork.libcamera.org/api/1.1/series/228/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=228", "date": "2019-04-02T00:54:02", "name": "cam: Add support to specify multiple stream configurations with hints", "version": 1, "mbox": "https://patchwork.libcamera.org/series/228/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/841/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/841/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9A366110D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Apr 2019 02:54:35 +0200 (CEST)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid e233bb2b-54e1-11e9-846a-005056917a89;\n\tTue, 02 Apr 2019 02:54:35 +0200 (CEST)" ], "X-Halon-ID": "e233bb2b-54e1-11e9-846a-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 2 Apr 2019 02:54:06 +0200", "Message-Id": "<20190402005406.25097-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190402005406.25097-1-niklas.soderlund@ragnatech.se>", "References": "<20190402005406.25097-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/4] cam: Allow cameras with more then one\n\tstream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 02 Apr 2019 00:54:36 -0000" }, "content": "The libcamera API and the cam tool is now ready to make use of cameras\nwith more then one stream. Remove the limitation in the tool which\ndisallows cameras which provides more then one stream.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/main.cpp | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 6aed4073f70d37a2..9fb29fc8995001f6 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -317,14 +317,6 @@ int main(int argc, char **argv)\n \t\t\tgoto out;\n \t\t}\n \n-\t\tconst std::set<Stream *> &streams = camera->streams();\n-\t\tif (streams.size() != 1) {\n-\t\t\tstd::cout << \"Camera has \" << streams.size()\n-\t\t\t\t << \" streams, only 1 is supported\"\n-\t\t\t\t << std::endl;\n-\t\t\tgoto out;\n-\t\t}\n-\n \t\tif (camera->acquire()) {\n \t\t\tstd::cout << \"Failed to acquire camera\" << std::endl;\n \t\t\tgoto out;\n", "prefixes": [ "libcamera-devel", "4/4" ] }