Patch Detail
Show a patch.
GET /api/1.1/patches/787/?format=api
{ "id": 787, "url": "https://patchwork.libcamera.org/api/1.1/patches/787/?format=api", "web_url": "https://patchwork.libcamera.org/patch/787/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190322104350.31091-5-kieran.bingham@ideasonboard.com>", "date": "2019-03-22T10:43:50", "name": "[libcamera-devel,4/4] libcamera: log: Fallback to getenv on non-gnu systems", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bd71882f026a39d77dc7e06a911f216a33ac5f74", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/787/mbox/", "series": [ { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/series/216/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=216", "date": "2019-03-22T10:43:46", "name": "Cleanup and non-GNU C library support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/216/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/787/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/787/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84469611A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Mar 2019 11:44:00 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DEAF111BE;\n\tFri, 22 Mar 2019 11:43:55 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1553251436;\n\tbh=ovX6/D4vHLNwrP4WLTjXURiz1kcNHxYHUGxPg+rPDyg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dIMm8KF2paPezzCozOr3qyEu9WcUcsFfu30dNWWtN5RxzV3gE/hK5ItfyDneKs4Ui\n\t4pOtwxS1IblYmEe9JBUbd0F6zm3ZTZ3KEAlHhidPEdixr6E6je8ZPYSjbB5x1qQnZj\n\tVmt9eKGiPq3ThRscf5IHT1xrV50ovYBCaSs6jJ98=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 22 Mar 2019 10:43:50 +0000", "Message-Id": "<20190322104350.31091-5-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20190322104350.31091-1-kieran.bingham@ideasonboard.com>", "References": "<20190322104350.31091-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/4] libcamera: log: Fallback to getenv on\n\tnon-gnu systems", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 22 Mar 2019 10:44:01 -0000" }, "content": "The secure_getenv() call is not provided by all toolchains. Support\ncompilation without this feature by falling back to the default getenv()\nfunctionality.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/log.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\nindex 7d930cd6b99e..a44bd941e615 100644\n--- a/src/libcamera/log.cpp\n+++ b/src/libcamera/log.cpp\n@@ -49,6 +49,15 @@\n \n namespace libcamera {\n \n+\n+/*\n+ * secure_getenv is a GNU-specific extension to the C-Library.\n+ * fall back to the default getenv when it is not available.\n+ */\n+#ifndef HAVE_SECURE_GETENV\n+#define secure_getenv getenv\n+#endif\n+\n /**\n * \\brief Message logger\n *\n", "prefixes": [ "libcamera-devel", "4/4" ] }