Patch Detail
Show a patch.
GET /api/1.1/patches/700/?format=api
{ "id": 700, "url": "https://patchwork.libcamera.org/api/1.1/patches/700/?format=api", "web_url": "https://patchwork.libcamera.org/patch/700/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190301154103.19588-6-jacopo@jmondi.org>", "date": "2019-03-01T15:41:03", "name": "[libcamera-devel,v7,5/5] libcamera: v4l2_device: Cosmetic update", "commit_ref": "ba90504cace9f2e53e47e0f9573604ff8e73ed7e", "pull_url": null, "state": "accepted", "archived": false, "hash": "33eefe22deb85bad23fc6f75c7b2a974d3cfa027", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/700/mbox/", "series": [ { "id": 201, "url": "https://patchwork.libcamera.org/api/1.1/series/201/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=201", "date": "2019-03-01T15:40:58", "name": "v4l2_(sub)dev: improvements and tests", "version": 7, "mbox": "https://patchwork.libcamera.org/series/201/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/700/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/700/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF680610C3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Mar 2019 16:40:45 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4EEF8C0010;\n\tFri, 1 Mar 2019 15:40:45 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Mar 2019 16:41:03 +0100", "Message-Id": "<20190301154103.19588-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190301154103.19588-1-jacopo@jmondi.org>", "References": "<20190301154103.19588-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 5/5] libcamera: v4l2_device: Cosmetic\n\tupdate", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 01 Mar 2019 15:40:46 -0000" }, "content": "Cosmetic update of V4L2Device class: remove the return type from Doxygen\ndocumentation of inline functions.\n\nCosmetic update, no functional changes intended.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_device.cpp | 32 ++++++++++++++++----------------\n 1 file changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex b19cf9f78029..ec4ab1587c60 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -37,56 +37,56 @@ LOG_DEFINE_CATEGORY(V4L2)\n */\n \n /**\n- * \\fn const char *V4L2Capability::driver()\n+ * \\fn V4L2Capability::driver()\n * \\brief Retrieve the driver module name\n * \\return The string containing the name of the driver module\n */\n \n /**\n- * \\fn const char *V4L2Capability::card()\n+ * \\fn V4L2Capability::card()\n * \\brief Retrieve the device card name\n * \\return The string containing the device name\n */\n \n /**\n- * \\fn const char *V4L2Capability::bus_info()\n+ * \\fn V4L2Capability::bus_info()\n * \\brief Retrieve the location of the device in the system\n * \\return The string containing the device location\n */\n \n /**\n- * \\fn unsigned int V4L2Capability::device_caps()\n+ * \\fn V4L2Capability::device_caps()\n * \\brief Retrieve the capabilities of the device\n * \\return The device specific capabilities if V4L2_CAP_DEVICE_CAPS is set or\n * \t driver capabilities otherwise\n */\n \n /**\n- * \\fn bool V4L2Capability::isMultiplanar()\n+ * \\fn V4L2Capability::isMultiplanar()\n * \\brief Identify if the device implements the V4L2 multiplanar APIs\n * \\return True if the device supports multiplanar APIs\n */\n \n /**\n- * \\fn bool V4L2Capability::isCapture()\n+ * \\fn V4L2Capability::isCapture()\n * \\brief Identify if the device captures data\n * \\return True if the device can capture data\n */\n \n /**\n- * \\fn bool V4L2Capability::isOutput()\n+ * \\fn V4L2Capability::isOutput()\n * \\brief Identify if the device outputs data\n * \\return True if the device can output data\n */\n \n /**\n- * \\fn bool V4L2Capability::isVideo()\n+ * \\fn V4L2Capability::isVideo()\n * \\brief Identify if the device captures or outputs images\n * \\return True if the device can capture or output images\n */\n \n /**\n- * \\fn bool V4L2Capability::isMeta()\n+ * \\fn V4L2Capability::isMeta()\n * \\brief Identify if the device captures or outputs image meta-data\n *\n * \\todo Add support for META_CAPTURE introduced in Linux v5.0\n@@ -95,25 +95,25 @@ LOG_DEFINE_CATEGORY(V4L2)\n */\n \n /**\n- * \\fn bool V4L2Capability::isVideoCapture()\n+ * \\fn V4L2Capability::isVideoCapture()\n * \\brief Identify if the device captures images\n * \\return True if the device can capture images\n */\n \n /**\n- * \\fn bool V4L2Capability::isVideoOutput()\n+ * \\fn V4L2Capability::isVideoOutput()\n * \\brief Identify if the device outputs images\n * \\return True if the device can output images\n */\n \n /**\n- * \\fn bool V4L2Capability::isMetaCapture()\n+ * \\fn V4L2Capability::isMetaCapture()\n * \\brief Identify if the device captures image meta-data\n * \\return True if the device can capture image meta-data\n */\n \n /**\n- * \\fn bool V4L2Capability::hasStreaming()\n+ * \\fn V4L2Capability::hasStreaming()\n * \\brief Determine if the device can perform Streaming I/O\n * \\return True if the device provides Streaming I/O IOCTLs\n */\n@@ -371,19 +371,19 @@ void V4L2Device::close()\n }\n \n /**\n- * \\fn const char *V4L2Device::driverName()\n+ * \\fn V4L2Device::driverName()\n * \\brief Retrieve the name of the V4L2 device driver\n * \\return The string containing the driver name\n */\n \n /**\n- * \\fn const char *V4L2Device::deviceName()\n+ * \\fn V4L2Device::deviceName()\n * \\brief Retrieve the name of the V4L2 device\n * \\return The string containing the device name\n */\n \n /**\n- * \\fn const char *V4L2Device::busName()\n+ * \\fn V4L2Device::busName()\n * \\brief Retrieve the location of the device in the system\n * \\return The string containing the device location\n */\n", "prefixes": [ "libcamera-devel", "v7", "5/5" ] }