Patch Detail
Show a patch.
GET /api/1.1/patches/648/?format=api
{ "id": 648, "url": "https://patchwork.libcamera.org/api/1.1/patches/648/?format=api", "web_url": "https://patchwork.libcamera.org/patch/648/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190228021626.15062-2-niklas.soderlund@ragnatech.se>", "date": "2019-02-28T02:16:23", "name": "[libcamera-devel,v2,1/4] cam: fix order camera is operated on", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "064daa60ddcb4ee400651ea8b6351fde06fd9636", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/648/mbox/", "series": [ { "id": 195, "url": "https://patchwork.libcamera.org/api/1.1/series/195/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=195", "date": "2019-02-28T02:16:23", "name": "libcamera: improve validation of camera operations", "version": 2, "mbox": "https://patchwork.libcamera.org/series/195/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/648/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/648/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8969F610B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Feb 2019 03:16:36 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid de04a93a-3afe-11e9-985a-005056917f90;\n\tThu, 28 Feb 2019 03:16:33 +0100 (CET)" ], "X-Halon-ID": "de04a93a-3afe-11e9-985a-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 28 Feb 2019 03:16:23 +0100", "Message-Id": "<20190228021626.15062-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190228021626.15062-1-niklas.soderlund@ragnatech.se>", "References": "<20190228021626.15062-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/4] cam: fix order camera is operated\n\ton", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 Feb 2019 02:16:36 -0000" }, "content": "Upcoming enforcing of order the camera shall be operate on is not\ncompatible with the cam utility. Requests shall be queued after the\ncamera is started, not before.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/main.cpp | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 4c2df583fe8e99b7..8df8844c33a2d052 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -133,6 +133,7 @@ static int capture()\n \tint ret;\n \n \tstd::vector<Stream *> streams = camera->streams();\n+\tstd::vector<Request *> requests;\n \n \tret = configureStreams(camera.get(), streams);\n \tif (ret < 0) {\n@@ -169,21 +170,24 @@ static int capture()\n \t\t\tgoto out;\n \t\t}\n \n-\t\tret = camera->queueRequest(request);\n-\t\tif (ret < 0) {\n-\t\t\tstd::cerr << \"Can't queue request\" << std::endl;\n-\t\t\tgoto out;\n-\t\t}\n+\t\trequests.push_back(request);\n \t}\n \n-\tstd::cout << \"Capture until user interrupts by SIGINT\" << std::endl;\n-\n \tret = camera->start();\n \tif (ret) {\n \t\tstd::cout << \"Failed to start capture\" << std::endl;\n \t\tgoto out;\n \t}\n \n+\tfor (Request *request : requests) {\n+\t\tret = camera->queueRequest(request);\n+\t\tif (ret < 0) {\n+\t\t\tstd::cerr << \"Can't queue request\" << std::endl;\n+\t\t\tgoto out;\n+\t\t}\n+\t}\n+\n+\tstd::cout << \"Capture until user interrupts by SIGINT\" << std::endl;\n \tret = loop->exec();\n \n \tret = camera->stop();\n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }