Patch Detail
Show a patch.
GET /api/1.1/patches/597/?format=api
{ "id": 597, "url": "https://patchwork.libcamera.org/api/1.1/patches/597/?format=api", "web_url": "https://patchwork.libcamera.org/patch/597/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190220143736.529-4-niklas.soderlund@ragnatech.se>", "date": "2019-02-20T14:37:35", "name": "[libcamera-devel,3/4] cam: fix printing of camera name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f918140e52daa03c35ddf0e84403a9b76e4c91a7", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/597/mbox/", "series": [ { "id": 187, "url": "https://patchwork.libcamera.org/api/1.1/series/187/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=187", "date": "2019-02-20T14:37:32", "name": "cam: improve error paths", "version": 1, "mbox": "https://patchwork.libcamera.org/series/187/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/597/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/597/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D44F1601E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Feb 2019 15:38:50 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 3a84663d-351d-11e9-b530-005056917a89;\n\tWed, 20 Feb 2019 15:38:46 +0100 (CET)" ], "X-Halon-ID": "3a84663d-351d-11e9-b530-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 Feb 2019 15:37:35 +0100", "Message-Id": "<20190220143736.529-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190220143736.529-1-niklas.soderlund@ragnatech.se>", "References": "<20190220143736.529-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] cam: fix printing of camera name", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 20 Feb 2019 14:38:51 -0000" }, "content": "Since commit c8c546fe99a343c1 (\"cam: options: Add option type handling\nto options parser\") introduced type handling for options the context the\noption is read became important. When reading the camera option for\nprinting there is no explicit context to print it as a string and\ninstead the int context was chosen resulting in:\n\n $ cam --camera foo\n Camera 0 not found\n\nWhile the expected output is:\n\n $ cam --camera foo\n Camera foo not found\n\nFix this by providing the correct context for the camera option when\nprinting it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/main.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 30267970a2c8485f..522d2f0d3373dc25 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -233,7 +233,8 @@ int main(int argc, char **argv)\n \tif (options.isSet(OptCamera)) {\n \t\tcamera = cm->get(options[OptCamera]);\n \t\tif (!camera) {\n-\t\t\tstd::cout << \"Camera \" << options[OptCamera]\n+\t\t\tstd::cout << \"Camera \"\n+\t\t\t\t << std::string(options[OptCamera])\n \t\t\t\t << \" not found\" << std::endl;\n \t\t\tgoto out;\n \t\t}\n", "prefixes": [ "libcamera-devel", "3/4" ] }