Patch Detail
Show a patch.
GET /api/1.1/patches/596/?format=api
{ "id": 596, "url": "https://patchwork.libcamera.org/api/1.1/patches/596/?format=api", "web_url": "https://patchwork.libcamera.org/patch/596/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190220143736.529-3-niklas.soderlund@ragnatech.se>", "date": "2019-02-20T14:37:34", "name": "[libcamera-devel,2/4] cam: improve error checking when capturing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9c0f9aeacc1e988a0d27bc38eefd2d526b0dc3a4", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/596/mbox/", "series": [ { "id": 187, "url": "https://patchwork.libcamera.org/api/1.1/series/187/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=187", "date": "2019-02-20T14:37:32", "name": "cam: improve error paths", "version": 1, "mbox": "https://patchwork.libcamera.org/series/187/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/596/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/596/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CC90600FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Feb 2019 15:38:49 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 3a18f3d9-351d-11e9-b530-005056917a89;\n\tWed, 20 Feb 2019 15:38:46 +0100 (CET)" ], "X-Halon-ID": "3a18f3d9-351d-11e9-b530-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 Feb 2019 15:37:34 +0100", "Message-Id": "<20190220143736.529-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190220143736.529-1-niklas.soderlund@ragnatech.se>", "References": "<20190220143736.529-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/4] cam: improve error checking when\n\tcapturing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 20 Feb 2019 14:38:49 -0000" }, "content": "The return value when start() and stop() the camera should be checked\nand handled.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/main.cpp | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex b034eb25429abeb3..30267970a2c8485f 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -183,11 +183,18 @@ static int capture()\n \t}\n \n \tstd::cout << \"Capture until user interrupts by SIGINT\" << std::endl;\n-\tcamera->start();\n+\n+\tret = camera->start();\n+\tif (ret) {\n+\t\tstd::cout << \"Failed to start capture\" << std::endl;\n+\t\tgoto out;\n+\t}\n \n \tret = loop->exec();\n \n-\tcamera->stop();\n+\tret = camera->stop();\n+\tif (ret)\n+\t\tstd::cout << \"Failed to stop capture\" << std::endl;\n out:\n \tcamera->freeBuffers();\n \n", "prefixes": [ "libcamera-devel", "2/4" ] }