Patch Detail
Show a patch.
GET /api/1.1/patches/566/?format=api
{ "id": 566, "url": "https://patchwork.libcamera.org/api/1.1/patches/566/?format=api", "web_url": "https://patchwork.libcamera.org/patch/566/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190213122035.25309-3-kieran.bingham@ideasonboard.com>", "date": "2019-02-13T12:20:34", "name": "[libcamera-devel,2/3] libcamera: v4l2_subdevice: Fix LOG usage", "commit_ref": "8cdc3148adb75e7854e8a1756de6095d8faf1656", "pull_url": null, "state": "accepted", "archived": false, "hash": "34489114b21e09194d8c6ddc6d73a73bc1722dd0", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/566/mbox/", "series": [ { "id": 179, "url": "https://patchwork.libcamera.org/api/1.1/series/179/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=179", "date": "2019-02-13T12:20:32", "name": "Fix LOG usage", "version": 1, "mbox": "https://patchwork.libcamera.org/series/179/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/566/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/566/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E320610B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 13:20:40 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9988C5B6;\n\tWed, 13 Feb 2019 13:20:39 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550060439;\n\tbh=IITo5ms7VHJenP7+p0UxkkCCMeF+oydJnjSvvdFm3I0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nsoc5doZNai14j/6s9rGnq5hhKMeomjnNY6uME+azRWEnKwfu8yFWJeAcag2BIMqg\n\tsL7vggG0kA/zf5rmotM+NJH+0CQyDXvM604lbZXam3Fc461o58V5vXAGYboI6woaP0\n\tWXjW0d3PjeO3DGpLI/jEhyKLseYEaOYFzoFEFzFc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 13 Feb 2019 12:20:34 +0000", "Message-Id": "<20190213122035.25309-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20190213122035.25309-1-kieran.bingham@ideasonboard.com>", "References": "<20190213122035.25309-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Fix LOG\n\tusage", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 13 Feb 2019 12:20:40 -0000" }, "content": "Add the V4L2Subdev category to the last LOG() call requiring it.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/v4l2_subdevice.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 1d5b11115dbb..17f715fe707a 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -223,7 +223,8 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format)\n \tint ret = ioctl(fd_, VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n \tif (ret) {\n \t\tret = -errno;\n-\t\tLOG(Error) << \"Unable to set format: \" << strerror(-ret);\n+\t\tLOG(V4L2Subdev, Error)\n+\t\t\t<< \"Unable to set format: \" << strerror(-ret);\n \t\treturn ret;\n \t}\n \n", "prefixes": [ "libcamera-devel", "2/3" ] }