Patch Detail
Show a patch.
GET /api/1.1/patches/561/?format=api
{ "id": 561, "url": "https://patchwork.libcamera.org/api/1.1/patches/561/?format=api", "web_url": "https://patchwork.libcamera.org/patch/561/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190212223702.9582-1-laurent.pinchart@ideasonboard.com>", "date": "2019-02-12T22:37:00", "name": "[libcamera-devel,1/3] libcamera: pipeline_handler: Disconnect MediaDevice::disconnected signal", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0a19a9e7b8541503b6f13f85a5961c4bfa7bb74d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/561/mbox/", "series": [ { "id": 178, "url": "https://patchwork.libcamera.org/api/1.1/series/178/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=178", "date": "2019-02-12T22:37:00", "name": "[libcamera-devel,1/3] libcamera: pipeline_handler: Disconnect MediaDevice::disconnected signal", "version": 1, "mbox": "https://patchwork.libcamera.org/series/178/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/561/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/561/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 786C160B21\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Feb 2019 23:37:09 +0100 (CET)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB56585\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Feb 2019 23:37:08 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550011029;\n\tbh=SlcslwDe9qmust3GNJIXAERP23Vo29Ja8Bw4muq/2yw=;\n\th=From:To:Subject:Date:From;\n\tb=f1IY5svNm2eM4nzsK4nIyYbm7uUj6EfhvP5GCK3Sa6cID4YRmO+2FzcC82nutcEsF\n\twKJUVFgVRkMIoL52eqTZO0mChXXx7dsKWH3u96nZGwoMHTwzDPIUI34FjnxmBLRs2C\n\t53aMnCRYFNuHeqISKRdBN0Iw0egVeIHZnGb57WiU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 13 Feb 2019 00:37:00 +0200", "Message-Id": "<20190212223702.9582-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler:\n\tDisconnect MediaDevice::disconnected signal", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 Feb 2019 22:37:09 -0000" }, "content": "The pipeline handler connects the disconnected signal of MediaDevice\ninstances registered for hotplug handling to a member slot. Disconnect\nthe signal when the slot is called, as the pipeline handler will be\ndeleted.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 4e111d6d2f55..616838fed702 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -241,6 +241,8 @@ void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n */\n void PipelineHandler::mediaDeviceDisconnected(MediaDevice *media)\n {\n+\tmedia->disconnected.disconnect(this);\n+\n \tif (cameras_.empty())\n \t\treturn;\n \n", "prefixes": [ "libcamera-devel", "1/3" ] }