Patch Detail
Show a patch.
GET /api/1.1/patches/510/?format=api
{ "id": 510, "url": "https://patchwork.libcamera.org/api/1.1/patches/510/?format=api", "web_url": "https://patchwork.libcamera.org/patch/510/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190205000702.15370-8-niklas.soderlund@ragnatech.se>", "date": "2019-02-05T00:07:02", "name": "[libcamera-devel,RFC,7/7] libcamera: pipeline: uvcvideo: add camera start and stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a1ac4fa3382a9e3cec6f10771645237c9957c8e2", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": { "id": 16, "url": "https://patchwork.libcamera.org/api/1.1/users/16/?format=api", "username": "neg", "first_name": "Niklas", "last_name": "Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "mbox": "https://patchwork.libcamera.org/patch/510/mbox/", "series": [ { "id": 168, "url": "https://patchwork.libcamera.org/api/1.1/series/168/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=168", "date": "2019-02-05T00:06:55", "name": "libcamera: extend camera and pipeline to support requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/168/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/510/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/510/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDEFD60DC5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Feb 2019 01:07:59 +0100 (CET)", "from localhost.localdomain (unknown [81.164.19.127])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 177e89ee-28da-11e9-b530-005056917a89;\n\tTue, 05 Feb 2019 01:07:57 +0100 (CET)" ], "X-Halon-ID": "177e89ee-28da-11e9-b530-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Feb 2019 01:07:02 +0100", "Message-Id": "<20190205000702.15370-8-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190205000702.15370-1-niklas.soderlund@ragnatech.se>", "References": "<20190205000702.15370-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 7/7] libcamera: pipeline: uvcvideo: add\n\tcamera start and stop", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 05 Feb 2019 00:08:00 -0000" }, "content": "Expand the stubs to actually start and stop the UVC video device.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/uvcvideo.cpp | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex 632a4b4b09189240..8c0d2c09aafa5f37 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -116,13 +116,16 @@ int PipelineHandlerUVC::freeBuffers(Camera *camera)\n \n int PipelineHandlerUVC::start(const Camera *camera)\n {\n-\tLOG(UVC, Error) << \"TODO: start camera\";\n-\treturn 0;\n+\tLOG(UVC, Debug) << \"Stream On\";\n+\n+\treturn video_->streamOn();\n }\n \n void PipelineHandlerUVC::stop(const Camera *camera)\n {\n-\tLOG(UVC, Error) << \"TODO: stop camera\";\n+\tLOG(UVC, Debug) << \"Stream Off\";\n+\n+\tvideo_->streamOff();\n }\n \n int PipelineHandlerUVC::queueRequest(const Camera *camera, Request *request)\n", "prefixes": [ "libcamera-devel", "RFC", "7/7" ] }