Patch Detail
Show a patch.
GET /api/1.1/patches/51/?format=api
{ "id": 51, "url": "https://patchwork.libcamera.org/api/1.1/patches/51/?format=api", "web_url": "https://patchwork.libcamera.org/patch/51/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20181214133143.18281-1-laurent.pinchart@ideasonboard.com>", "date": "2018-12-14T13:31:43", "name": "[libcamera-devel] Documentation: Remove | on the left side of diagrams", "commit_ref": "d416f42cceed1714d6543e3f014b815be5d1a5c6", "pull_url": null, "state": "accepted", "archived": false, "hash": "e89ca63aa5590d1ac7310ba8a3164a49d4fe7626", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/51/mbox/", "series": [ { "id": 26, "url": "https://patchwork.libcamera.org/api/1.1/series/26/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=26", "date": "2018-12-14T13:31:43", "name": "[libcamera-devel] Documentation: Remove | on the left side of diagrams", "version": 1, "mbox": "https://patchwork.libcamera.org/series/26/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/51/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/51/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D91860B0C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Dec 2018 14:31:00 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D2DA1549\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Dec 2018 14:30:59 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544794260;\n\tbh=sEapCMEA68TvttKuPjQzubcV5R1FAKwYZtau5NpB0es=;\n\th=From:To:Subject:Date:From;\n\tb=r0ASOCSP7lZ6K8Y/EA6KcEjF4/dADwKvdZiwUIB0vGL21/HFlWcZkxLpc2lnCMGB7\n\tVSz/58HLe5B5A/vyVnSjSOre54bTadmxTiRfN/89zz4AbSBNptnMKsjGuGBUr5OeyX\n\ttCMfYnAuDW2OqL2wkhu83X0/uQypJA6USdDTRlU0=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 14 Dec 2018 15:31:43 +0200", "Message-Id": "<20181214133143.18281-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] Documentation: Remove | on the left side\n\tof diagrams", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 14 Dec 2018 13:31:00 -0000" }, "content": "There's no need to add a character on the left side of the ascii art\ndiagrams, provided that we indent them properly. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n Documentation/docs.rst | 162 ++++++++++++++++++++---------------------\n 1 file changed, 81 insertions(+), 81 deletions(-)", "diff": "diff --git a/Documentation/docs.rst b/Documentation/docs.rst\nindex 4bbcd9aa35bf..c3e24bb9797c 100644\n--- a/Documentation/docs.rst\n+++ b/Documentation/docs.rst\n@@ -150,45 +150,45 @@ Camera Stack\n \n ::\n \n- | a c / +-------------+ +-------------+ +-------------+ +-------------+\n- | p a | | Native | | Framework | | Native | | Android |\n- | p t | | V4L2 | | Application | | libcamera | | Camera |\n- | l i | | Application | | (gstreamer) | | Application | | Framework |\n- | i o \\ +-------------+ +-------------+ +-------------+ +-------------+\n- | n ^ ^ ^ ^\n- | | | | |\n- | l a | | | |\n- | i d v v | v\n- | b a / +-------------+ +-------------+ | +-------------+\n- | c p | | V4L2 | | Camera | | | Android |\n- | a t | | Compat. | | Framework | | | Camera |\n- | m a | | | | (gstreamer) | | | HAL |\n- | e t \\ +-------------+ +-------------+ | +-------------+\n- | r i ^ ^ | ^\n- | a o | | | |\n- | n | | | |\n- | / | ,................................................\n- | | | ! : Language : !\n- | l f | | ! : Bindings : !\n- | i r | | ! : (optional) : !\n- | b a | | \\...............................................'\n- | c m | | | | |\n- | a e | | | | |\n- | m w | v v v v\n- | e o | +----------------------------------------------------------------+\n- | r r | | |\n- | a k | | libcamera |\n- | | | |\n- | \\ +----------------------------------------------------------------+\n- | ^ ^ ^\n- | Userspace | | |\n- | ------------------------ | ---------------- | ---------------- | ---------------\n- | Kernel | | |\n- | v v v\n- | +-----------+ +-----------+ +-----------+\n- | | Media | <--> | Video | <--> | V4L2 |\n- | | Device | | Device | | Subdev |\n- | +-----------+ +-----------+ +-----------+\n+ a c / +-------------+ +-------------+ +-------------+ +-------------+\n+ p a | | Native | | Framework | | Native | | Android |\n+ p t | | V4L2 | | Application | | libcamera | | Camera |\n+ l i | | Application | | (gstreamer) | | Application | | Framework |\n+ i o \\ +-------------+ +-------------+ +-------------+ +-------------+\n+ n ^ ^ ^ ^\n+ | | | |\n+ l a | | | |\n+ i d v v | v\n+ b a / +-------------+ +-------------+ | +-------------+\n+ c p | | V4L2 | | Camera | | | Android |\n+ a t | | Compat. | | Framework | | | Camera |\n+ m a | | | | (gstreamer) | | | HAL |\n+ e t \\ +-------------+ +-------------+ | +-------------+\n+ r i ^ ^ | ^\n+ a o | | | |\n+ n | | | |\n+ / | ,................................................\n+ | | ! : Language : !\n+ l f | | ! : Bindings : !\n+ i r | | ! : (optional) : !\n+ b a | | \\...............................................'\n+ c m | | | | |\n+ a e | | | | |\n+ m w | v v v v\n+ e o | +----------------------------------------------------------------+\n+ r r | | |\n+ a k | | libcamera |\n+ | | |\n+ \\ +----------------------------------------------------------------+\n+ ^ ^ ^\n+ Userspace | | |\n+ ------------------------ | ---------------- | ---------------- | ---------------\n+ Kernel | | |\n+ v v v\n+ +-----------+ +-----------+ +-----------+\n+ | Media | <--> | Video | <--> | V4L2 |\n+ | Device | | Device | | Subdev |\n+ +-----------+ +-----------+ +-----------+\n \n The camera stack comprises four software layers. From bottom to top:\n \n@@ -226,48 +226,48 @@ libcamera Architecture\n \n ::\n \n- | ---------------------------< libcamera Public API >---------------------------\n- | ^ ^\n- | | |\n- | v v\n- | +-------------+ +-------------------------------------------------+\n- | | Camera | | Camera Device |\n- | | Devices | | +---------------------------------------------+ |\n- | | Manager | | | Device-Agnostic | |\n- | +-------------+ | | | |\n- | ^ | | +------------------------+ |\n- | | | | | ~~~~~~~~~~~~~~~~~~~~~ |\n- | | | | | { +---------------+ } |\n- | | | | | } | ////Image//// | { |\n- | | | | | <-> | /Processing// | } |\n- | | | | | } | /Algorithms// | { |\n- | | | | | { +---------------+ } |\n- | | | | | ~~~~~~~~~~~~~~~~~~~~~ |\n- | | | | | ======================== |\n- | | | | | +---------------+ |\n- | | | | | | //Pipeline/// | |\n- | | | | | <-> | ///Handler/// | |\n- | | | | | | ///////////// | |\n- | | | +--------------------+ +---------------+ |\n- | | | Device-Specific |\n- | | +-------------------------------------------------+\n- | | ^ ^\n- | | | |\n- | v v v\n- | +--------------------------------------------------------------------+\n- | | Helpers and Support Classes |\n- | | +-------------+ +-------------+ +-------------+ +-------------+ |\n- | | | MC & V4L2 | | Buffers | | Sandboxing | | Plugins | |\n- | | | Support | | Allocator | | IPC | | Manager | |\n- | | +-------------+ +-------------+ +-------------+ +-------------+ |\n- | | +-------------+ +-------------+ |\n- | | | Pipeline | | ... | |\n- | | | Runner | | | |\n- | | +-------------+ +-------------+ |\n- | +--------------------------------------------------------------------+\n- |\n- | /// Device-Specific Components\n- | ~~~ Sandboxing\n+ ---------------------------< libcamera Public API >---------------------------\n+ ^ ^\n+ | |\n+ v v\n+ +-------------+ +-------------------------------------------------+\n+ | Camera | | Camera Device |\n+ | Devices | | +---------------------------------------------+ |\n+ | Manager | | | Device-Agnostic | |\n+ +-------------+ | | | |\n+ ^ | | +------------------------+ |\n+ | | | | ~~~~~~~~~~~~~~~~~~~~~ |\n+ | | | | { +---------------+ } |\n+ | | | | } | ////Image//// | { |\n+ | | | | <-> | /Processing// | } |\n+ | | | | } | /Algorithms// | { |\n+ | | | | { +---------------+ } |\n+ | | | | ~~~~~~~~~~~~~~~~~~~~~ |\n+ | | | | ======================== |\n+ | | | | +---------------+ |\n+ | | | | | //Pipeline/// | |\n+ | | | | <-> | ///Handler/// | |\n+ | | | | | ///////////// | |\n+ | | +--------------------+ +---------------+ |\n+ | | Device-Specific |\n+ | +-------------------------------------------------+\n+ | ^ ^\n+ | | |\n+ v v v\n+ +--------------------------------------------------------------------+\n+ | Helpers and Support Classes |\n+ | +-------------+ +-------------+ +-------------+ +-------------+ |\n+ | | MC & V4L2 | | Buffers | | Sandboxing | | Plugins | |\n+ | | Support | | Allocator | | IPC | | Manager | |\n+ | +-------------+ +-------------+ +-------------+ +-------------+ |\n+ | +-------------+ +-------------+ |\n+ | | Pipeline | | ... | |\n+ | | Runner | | | |\n+ | +-------------+ +-------------+ |\n+ +--------------------------------------------------------------------+\n+ \n+ /// Device-Specific Components\n+ ~~~ Sandboxing\n \n While offering a unified API towards upper layers, and presenting\n itself as a single library, libcamera isn't monolithic. It exposes\n", "prefixes": [ "libcamera-devel" ] }