Patch Detail
Show a patch.
GET /api/1.1/patches/5/?format=api
{ "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/patches/5/?format=api", "web_url": "https://patchwork.libcamera.org/patch/5/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20181119175306.4729-1-laurent.pinchart@ideasonboard.com>", "date": "2018-11-19T17:53:06", "name": "[libcamera-devel] utils: ipu3: Add IPU3 raw capture unpack utility", "commit_ref": "23ac77dc4a096b92da7668e9ddfce10b22e73506", "pull_url": null, "state": "accepted", "archived": false, "hash": "a15c714b5011c31b878ee322dcf2f0f5357e8eaa", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/5/mbox/", "series": [ { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/series/3/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3", "date": "2018-11-19T17:53:06", "name": "[libcamera-devel] utils: ipu3: Add IPU3 raw capture unpack utility", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/5/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/5/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1AF960002\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Nov 2018 18:52:54 +0100 (CET)", "from avalon.telus (node-1w7jr9qt31lmhljbimrwzuuvx.ipv6.telus.net\n\t[IPv6:2001:569:7bf7:d700:e720:97a7:80b9:aadd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F5B755D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Nov 2018 18:52:53 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1542649974;\n\tbh=Y3SGZp1/THCQcYWdNt05qoTwz7hgVUwgl4g3E0qrO/w=;\n\th=From:To:Subject:Date:From;\n\tb=UfgFgxEHyyY7etXTlIa15hrWdk2YMhvp8ydWxS6PEvxwjdku3FfC5pQ8mPkQEFQ0c\n\tsEwRzc9XdPFWbAclmqzdoib3QFtCygGdnJzJyF9mjIZlgMyLYWjYTwrEEqkhPWlc1E\n\tyom/TygqigD55u67+g4BgrnEO7whzSaKhFYHvleI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 19 Nov 2018 19:53:06 +0200", "Message-Id": "<20181119175306.4729-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.18.1", "Subject": "[libcamera-devel] [PATCH] utils: ipu3: Add IPU3 raw capture unpack\n\tutility", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 19 Nov 2018 17:52:55 -0000" }, "content": "The IPU3 captures Bayer data in a 25-pixels-in-32-bytes packed format,\nwhich no standard tool can process. Add a quick implementation of data\nunpacking to turn raw binary files into 16 bits per pixel unpacked Bayer\ndata.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 3 +-\n utils/ipu3/ipu3-unpack.c | 93 ++++++++++++++++++++++++++++++++++++++++\n utils/ipu3/meson.build | 1 +\n utils/meson.build | 1 +\n 4 files changed, 97 insertions(+), 1 deletion(-)\n create mode 100644 utils/ipu3/ipu3-unpack.c\n create mode 100644 utils/ipu3/meson.build\n create mode 100644 utils/meson.build", "diff": "diff --git a/meson.build b/meson.build\nindex d1e186adb356..4b3d528c8932 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1,4 +1,4 @@\n-project('libcamera - supporting complex camera pipelines', 'cpp',\n+project('libcamera - supporting complex camera pipelines', 'c', 'cpp',\n version : '0.1',\n license : 'LGPL 2.1+')\n \n@@ -6,6 +6,7 @@ inc = include_directories('include')\n \n subdir('lib')\n subdir('test')\n+subdir('utils')\n \n pkg_mod = import('pkgconfig')\n pkg_mod.generate(libraries : libcamera,\ndiff --git a/utils/ipu3/ipu3-unpack.c b/utils/ipu3/ipu3-unpack.c\nnew file mode 100644\nindex 000000000000..2dce10385add\n--- /dev/null\n+++ b/utils/ipu3/ipu3-unpack.c\n@@ -0,0 +1,93 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * ipu3-unpack - Unpack IPU3 raw Bayer format to 16-bit Bayer\n+ *\n+ * Copyright 2018 Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n+ */\n+#define _GNU_SOURCE\n+\n+#include <errno.h>\n+#include <fcntl.h>\n+#include <stdint.h>\n+#include <stdio.h>\n+#include <string.h>\n+#include <sys/stat.h>\n+#include <sys/types.h>\n+#include <unistd.h>\n+\n+static void usage(const char *argv0)\n+{\n+\tprintf(\"Usage: %s input-file output-file\\n\", basename(argv0));\n+\tprintf(\"Unpack the IPU3 raw Bayer format to 16-bit Bayer\\n\");\n+}\n+\n+int main(int argc, char *argv[])\n+{\n+\tint in_fd;\n+\tint out_fd;\n+\tint ret;\n+\n+\tif (argc != 3) {\n+\t\tusage(argv[0]);\n+\t\treturn 1;\n+\t}\n+\n+\tin_fd = open(argv[1], O_RDONLY);\n+\tif (in_fd == -1) {\n+\t\tfprintf(stderr, \"Failed to open input file '%s': %s\\n\",\n+\t\t\targv[1], strerror(errno));\n+\t\treturn 1;\n+\t}\n+\n+\tout_fd = open(argv[2], O_WRONLY | O_TRUNC | O_CREAT, 0644);\n+\tif (out_fd == -1) {\n+\t\tfprintf(stderr, \"Failed to open output file '%s': %s\\n\",\n+\t\t\targv[2], strerror(errno));\n+\t\treturn 1;\n+\t}\n+\n+\twhile (1) {\n+\t\tuint8_t in_data[32];\n+\t\tuint8_t out_data[50];\n+\t\tunsigned int i;\n+\n+\t\tret = read(in_fd, in_data, 32);\n+\t\tif (ret == -1) {\n+\t\t\tfprintf(stderr, \"Failed to read input data: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\t\tgoto done;\n+\t\t}\n+\n+\t\tif (ret < 32) {\n+\t\t\tif (ret != 0)\n+\t\t\t\tfprintf(stderr, \"%u bytes of stray data at end of input\\n\",\n+\t\t\t\t\tret);\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tfor (i = 0; i < 25; ++i) {\n+\t\t\tunsigned int index = (i * 10) / 8;\n+\t\t\tunsigned int lsb_shift = (i * 10) % 8;\n+\t\t\tunsigned int msb_shift = 8 - lsb_shift;\n+\t\t\tuint16_t pixel;\n+\n+\t\t\tpixel = ((in_data[index+1] << msb_shift) & 0x3ff)\n+\t\t\t | ((in_data[index+0] >> lsb_shift) & 0x3ff);\n+\t\t\tout_data[i*2+0] = (pixel >> 0) & 0xff;\n+\t\t\tout_data[i*2+1] = (pixel >> 8) & 0xff;\n+\t\t}\n+\n+\t\tret = write(out_fd, out_data, 50);\n+\t\tif (ret < -1) {\n+\t\t\tfprintf(stderr, \"Failed to read input data: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\t\tgoto done;\n+\t\t}\n+\t}\n+\n+done:\n+\tclose(in_fd);\n+\tclose(out_fd);\n+\n+\treturn ret ? 1 : 0;\n+}\ndiff --git a/utils/ipu3/meson.build b/utils/ipu3/meson.build\nnew file mode 100644\nindex 000000000000..49c45856eea6\n--- /dev/null\n+++ b/utils/ipu3/meson.build\n@@ -0,0 +1 @@\n+ipu3_unpack = executable('ipu3-unpack', 'ipu3-unpack.c')\ndiff --git a/utils/meson.build b/utils/meson.build\nnew file mode 100644\nindex 000000000000..f434c79c0ae3\n--- /dev/null\n+++ b/utils/meson.build\n@@ -0,0 +1 @@\n+subdir('ipu3')\n", "prefixes": [ "libcamera-devel" ] }