Patch Detail
Show a patch.
GET /api/1.1/patches/474/?format=api
{ "id": 474, "url": "https://patchwork.libcamera.org/api/1.1/patches/474/?format=api", "web_url": "https://patchwork.libcamera.org/patch/474/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190201154248.15006-3-jacopo@jmondi.org>", "date": "2019-02-01T15:42:43", "name": "[libcamera-devel,2/7] libcamera: v4l2_device: Fix getFormatSingleplane ioclt", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5844d2bbd4f618ed177e15038eff8d61220d836d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/474/mbox/", "series": [ { "id": 162, "url": "https://patchwork.libcamera.org/api/1.1/series/162/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=162", "date": "2019-02-01T15:42:41", "name": "libcamera: v4l2_device: Address comments for s/g_fmt", "version": 1, "mbox": "https://patchwork.libcamera.org/series/162/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/474/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/474/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39DD660B10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Feb 2019 16:42:40 +0100 (CET)", "from uno.localdomain (unknown [91.183.179.147])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id DD2621BF207;\n\tFri, 1 Feb 2019 15:42:39 +0000 (UTC)" ], "X-Originating-IP": "91.183.179.147", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Feb 2019 16:42:43 +0100", "Message-Id": "<20190201154248.15006-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190201154248.15006-1-jacopo@jmondi.org>", "References": "<20190201154248.15006-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/7] libcamera: v4l2_device: Fix\n\tgetFormatSingleplane ioclt", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 01 Feb 2019 15:42:40 -0000" }, "content": "The single plane getFormat() function wrongly used the VIDIOC_S_FMT ioctl.\nFix that by using the more opportune VIDIOC_G_FMT one.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 26b6ff3..5ba89b9 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -305,7 +305,7 @@ int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *fmt)\n \tint ret;\n \n \tv4l2Fmt.type = bufferType_;\n-\tret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Fmt);\n+\tret = ioctl(fd_, VIDIOC_G_FMT, &v4l2Fmt);\n \tif (ret) {\n \t\tret = -errno;\n \t\tLOG(Error) << \"Unable to get format: \" << strerror(-ret);\n", "prefixes": [ "libcamera-devel", "2/7" ] }