Patch Detail
Show a patch.
GET /api/1.1/patches/473/?format=api
{ "id": 473, "url": "https://patchwork.libcamera.org/api/1.1/patches/473/?format=api", "web_url": "https://patchwork.libcamera.org/patch/473/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190201154248.15006-2-jacopo@jmondi.org>", "date": "2019-02-01T15:42:42", "name": "[libcamera-devel,1/7] libcamera: v4l2_device: Rename format() method to getFormat()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b4358a9716b73fde3be44f5bd7168c82a1cd45ee", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/473/mbox/", "series": [ { "id": 162, "url": "https://patchwork.libcamera.org/api/1.1/series/162/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=162", "date": "2019-02-01T15:42:41", "name": "libcamera: v4l2_device: Address comments for s/g_fmt", "version": 1, "mbox": "https://patchwork.libcamera.org/series/162/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/473/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/473/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B975B60B10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Feb 2019 16:42:39 +0100 (CET)", "from uno.localdomain (unknown [91.183.179.147])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 7B0ED1BF215;\n\tFri, 1 Feb 2019 15:42:39 +0000 (UTC)" ], "X-Originating-IP": "91.183.179.147", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Feb 2019 16:42:42 +0100", "Message-Id": "<20190201154248.15006-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190201154248.15006-1-jacopo@jmondi.org>", "References": "<20190201154248.15006-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/7] libcamera: v4l2_device: Rename\n\tformat() method to getFormat()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 01 Feb 2019 15:42:39 -0000" }, "content": "Rename format() to getFormat() to reflect the v4l2 API names more\nclosely.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/include/v4l2_device.h | 2 +-\n src/libcamera/v4l2_device.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h\nindex f68b2b1..70e3c00 100644\n--- a/src/libcamera/include/v4l2_device.h\n+++ b/src/libcamera/include/v4l2_device.h\n@@ -86,7 +86,7 @@ public:\n \tconst char *deviceName() const { return caps_.card(); }\n \tconst char *busName() const { return caps_.bus_info(); }\n \n-\tint format(V4L2DeviceFormat *fmt);\n+\tint getFormat(V4L2DeviceFormat *fmt);\n \tint setFormat(V4L2DeviceFormat *fmt);\n \n private:\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 5c415d0..26b6ff3 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -282,7 +282,7 @@ void V4L2Device::close()\n * \\brief Retrieve the image format set on the V4L2 device\n * \\return 0 for success, a negative error code otherwise\n */\n-int V4L2Device::format(V4L2DeviceFormat *fmt)\n+int V4L2Device::getFormat(V4L2DeviceFormat *fmt)\n {\n \treturn caps_.isMultiplanar() ? getFormatMultiplane(fmt) :\n \t\t\t\t getFormatSingleplane(fmt);\n", "prefixes": [ "libcamera-devel", "1/7" ] }