Patch Detail
Show a patch.
GET /api/1.1/patches/470/?format=api
{ "id": 470, "url": "https://patchwork.libcamera.org/api/1.1/patches/470/?format=api", "web_url": "https://patchwork.libcamera.org/patch/470/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190201092919.8336-1-laurent.pinchart@ideasonboard.com>", "date": "2019-02-01T09:29:19", "name": "[libcamera-devel] cam: options: Add explicit conversion methods to OptionValue", "commit_ref": "3fd5ade00c5da727184c6c5aa728d4ee27bb6ac2", "pull_url": null, "state": "accepted", "archived": false, "hash": "8e95722acd6ec2ec0fb3cf34e852de64c3ac7a37", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/470/mbox/", "series": [ { "id": 160, "url": "https://patchwork.libcamera.org/api/1.1/series/160/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=160", "date": "2019-02-01T09:29:19", "name": "[libcamera-devel] cam: options: Add explicit conversion methods to OptionValue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/160/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/470/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/470/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C7B560DB5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Feb 2019 10:29:27 +0100 (CET)", "from pendragon.ideasonboard.com (85-76-34-136-nat.elisa-mobile.fi\n\t[85.76.34.136])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A95C41;\n\tFri, 1 Feb 2019 10:29:25 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549013366;\n\tbh=0GOFqniVD6rVflnZ8gc4Mpr6B5x777IskxnLPUiAdCg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=dMkp5d6irwdW3xEaXOgGtHk9ASYaxDTnVD4ERf1RagyKiXVzBNOSDnBPFyTDrXgqW\n\tlLA8Gb+kJ4FfT8j4LeyZRQOELtkG5VAOXStTumKS4vO/FYWtRgoR57jxAc1Yaul+1P\n\tTRtuqI6qpmGuLy7FOQHcMPr7aEVz+LmTD9NkLxco=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Feb 2019 11:29:19 +0200", "Message-Id": "<20190201092919.8336-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] cam: options: Add explicit conversion\n\tmethods to OptionValue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 01 Feb 2019 09:29:27 -0000" }, "content": "The OptionValue class defines operators to convert the variant to all\nthe supported option types. As a convenience, add explicit methods to\nperform the same operations, avoiding the need to write long\nstatic_cast<>() statements in the caller.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.cpp | 19 +++++++++++++++++--\n src/cam/options.h | 4 ++++\n 2 files changed, 21 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 4c9f3a36d435..eb59376fa459 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -273,6 +273,21 @@ OptionValue::OptionValue(const KeyValueParser::Options &value)\n }\n \n OptionValue::operator int() const\n+{\n+\treturn toInteger();\n+}\n+\n+OptionValue::operator std::string() const\n+{\n+\treturn toString();\n+}\n+\n+OptionValue::operator KeyValueParser::Options() const\n+{\n+\treturn toKeyValues();\n+}\n+\n+int OptionValue::toInteger() const\n {\n \tif (type_ != OptionInteger)\n \t\treturn 0;\n@@ -280,7 +295,7 @@ OptionValue::operator int() const\n \treturn integer_;\n }\n \n-OptionValue::operator std::string() const\n+std::string OptionValue::toString() const\n {\n \tif (type_ != OptionString)\n \t\treturn std::string();\n@@ -288,7 +303,7 @@ OptionValue::operator std::string() const\n \treturn string_;\n }\n \n-OptionValue::operator KeyValueParser::Options() const\n+KeyValueParser::Options OptionValue::toKeyValues() const\n {\n \tif (type_ != OptionKeyValue)\n \t\treturn KeyValueParser::Options();\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex e1fd62ecd369..2d3aa50b5051 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -91,6 +91,10 @@ public:\n \toperator std::string() const;\n \toperator KeyValueParser::Options() const;\n \n+\tint toInteger() const;\n+\tstd::string toString() const;\n+\tKeyValueParser::Options toKeyValues() const;\n+\n private:\n \tOptionType type_;\n \tint integer_;\n", "prefixes": [ "libcamera-devel" ] }