Patch Detail
Show a patch.
GET /api/1.1/patches/464/?format=api
{ "id": 464, "url": "https://patchwork.libcamera.org/api/1.1/patches/464/?format=api", "web_url": "https://patchwork.libcamera.org/patch/464/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190131234721.22606-5-laurent.pinchart@ideasonboard.com>", "date": "2019-01-31T23:47:17", "name": "[libcamera-devel,v2,4/8] cam: options: Return whether addOption() succeeds or not", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3544ae565cfd3a64017b4c1fce68a03a1265cf72", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/464/mbox/", "series": [ { "id": 158, "url": "https://patchwork.libcamera.org/api/1.1/series/158/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=158", "date": "2019-01-31T23:47:13", "name": "cam: add --format option to configure a stream", "version": 2, "mbox": "https://patchwork.libcamera.org/series/158/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/464/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/464/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40F6B60DB8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Feb 2019 00:47:40 +0100 (CET)", "from pendragon.ideasonboard.com (85-76-34-136-nat.elisa-mobile.fi\n\t[85.76.34.136])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F23DC41;\n\tFri, 1 Feb 2019 00:47:37 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548978459;\n\tbh=6PJVBEe8jV7SblGMXUXzHMRm8JFa8eyopHb7bgDPGYs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r0zacOKv14p8VakAFcJs/C3JMA8oBqVsfaL4Pd0cH4CktrD0Iybdq+w/HOTTciLqs\n\tv8bRgMp+wRh2z+wIoKJmVgP1YmL8i0+fTWZu4vPYx+6CJSy6hQdY3V4/l4FZzKWtWa\n\teGRYCcl18e8TpqaC/g52PF0+MLHz2wMOaaGv47Hc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Feb 2019 01:47:17 +0200", "Message-Id": "<20190131234721.22606-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190131234721.22606-1-laurent.pinchart@ideasonboard.com>", "References": "<20190131234721.22606-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/8] cam: options: Return whether\n\taddOption() succeeds or not", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 31 Jan 2019 23:47:40 -0000" }, "content": "From: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nTo later extend the options handling to cover subparsing of arguments it\nwill be needed to know if the addition of the option itself was\nsuccessful or not. The information is already present in addOption()\nthis change just makes it available.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.cpp | 11 ++++++-----\n src/cam/options.h | 2 +-\n 2 files changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex f48bd1fcf1b4..c13022ce1b84 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -38,7 +38,7 @@ void OptionsBase<T>::clear()\n \n template class OptionsBase<int>;\n \n-void OptionsParser::addOption(int opt, const char *help, const char *name,\n+bool OptionsParser::addOption(int opt, const char *help, const char *name,\n \t\t\t OptionArgument argument, const char *argumentName)\n {\n \t/*\n@@ -46,18 +46,19 @@ void OptionsParser::addOption(int opt, const char *help, const char *name,\n \t * If an argument is accepted, it must be described by argumentName.\n \t */\n \tif (!isalnum(opt) && !name)\n-\t\treturn;\n+\t\treturn false;\n \tif (!help || help[0] == '\\0')\n-\t\treturn;\n+\t\treturn false;\n \tif (argument != ArgumentNone && !argumentName)\n-\t\treturn;\n+\t\treturn false;\n \n \t/* Reject duplicate options. */\n \tif (optionsMap_.find(opt) != optionsMap_.end())\n-\t\treturn;\n+\t\treturn false;\n \n \toptions_.push_back(Option({ opt, name, argument, argumentName, help }));\n \toptionsMap_[opt] = &options_.back();\n+\treturn true;\n }\n \n OptionsParser::Options OptionsParser::parse(int argc, char **argv)\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex 2bf1f160f3c0..2272385a0b83 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -49,7 +49,7 @@ public:\n \t{\n \t};\n \n-\tvoid addOption(int opt, const char *help, const char *name = nullptr,\n+\tbool addOption(int opt, const char *help, const char *name = nullptr,\n \t\t OptionArgument argument = ArgumentNone,\n \t\t const char *argumentName = nullptr);\n \n", "prefixes": [ "libcamera-devel", "v2", "4/8" ] }