Patch Detail
Show a patch.
GET /api/1.1/patches/461/?format=api
{ "id": 461, "url": "https://patchwork.libcamera.org/api/1.1/patches/461/?format=api", "web_url": "https://patchwork.libcamera.org/patch/461/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190131234721.22606-2-laurent.pinchart@ideasonboard.com>", "date": "2019-01-31T23:47:14", "name": "[libcamera-devel,v2,1/8] cam: options: Move enum OptionArgument", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f3f1a54c6d43d199471e355f2f20b24dcc106b55", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/461/mbox/", "series": [ { "id": 158, "url": "https://patchwork.libcamera.org/api/1.1/series/158/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=158", "date": "2019-01-31T23:47:13", "name": "cam: add --format option to configure a stream", "version": 2, "mbox": "https://patchwork.libcamera.org/series/158/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/461/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/461/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B93E60DB8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Feb 2019 00:47:36 +0100 (CET)", "from pendragon.ideasonboard.com (85-76-34-136-nat.elisa-mobile.fi\n\t[85.76.34.136])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3646F320;\n\tFri, 1 Feb 2019 00:47:33 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548978454;\n\tbh=oN48vyoiG7zLROp3gmz5rlpuRw9mHzuQ6euWvlppLJc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Tv3mTV2bz/G9JrKXLHjlGeHVbu3XAJR/4bTrtt1rQg25em6qoUxdesPKSRe2Dyi/B\n\tA1D8zhHL3pQc8IokYo9X6XQLk6iwz4C5OlhyFkHHSatXGLPDBSmquM6SgxhCQ5mhXH\n\tEnRG6ACC59EH+ExQ7PeuCyBMlsJcXs4//GvQsjqE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Feb 2019 01:47:14 +0200", "Message-Id": "<20190131234721.22606-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190131234721.22606-1-laurent.pinchart@ideasonboard.com>", "References": "<20190131234721.22606-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/8] cam: options: Move enum\n\tOptionArgument", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 31 Jan 2019 23:47:36 -0000" }, "content": "From: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nThe enumeration of the different possibilities for arguments can be used\nby other parser then OptionsParser. Move it outside the class to make it\nready to be used by other parsers.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/main.cpp | 3 +--\n src/cam/options.h | 12 ++++++------\n 2 files changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex cb98d302dcf3..bde47a8f1798 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -38,8 +38,7 @@ static int parseOptions(int argc, char *argv[])\n \tOptionsParser parser;\n \n \tparser.addOption(OptCamera, \"Specify which camera to operate on\",\n-\t\t\t \"camera\", OptionsParser::ArgumentRequired,\n-\t\t\t \"camera\");\n+\t\t\t \"camera\", ArgumentRequired, \"camera\");\n \tparser.addOption(OptHelp, \"Display this help message\", \"help\");\n \tparser.addOption(OptList, \"List all cameras\", \"list\");\n \ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex f99ea7300a71..491f6a316fff 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -11,15 +11,15 @@\n #include <map>\n #include <vector>\n \n+enum OptionArgument {\n+\tArgumentNone,\n+\tArgumentRequired,\n+\tArgumentOptional,\n+};\n+\n class OptionsParser\n {\n public:\n-\tenum OptionArgument {\n-\t\tArgumentNone,\n-\t\tArgumentRequired,\n-\t\tArgumentOptional,\n-\t};\n-\n \tclass Options {\n \tpublic:\n \t\tOptions();\n", "prefixes": [ "libcamera-devel", "v2", "1/8" ] }