Patch Detail
Show a patch.
GET /api/1.1/patches/448/?format=api
{ "id": 448, "url": "https://patchwork.libcamera.org/api/1.1/patches/448/?format=api", "web_url": "https://patchwork.libcamera.org/patch/448/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190130115615.17362-3-niklas.soderlund@ragnatech.se>", "date": "2019-01-30T11:56:11", "name": "[libcamera-devel,v5,2/6] libcamera: stream: add initial StreamConfiguration structure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c81def4d90703784a939a2e8dfc5238ba274a849", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/448/mbox/", "series": [ { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/series/156/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=156", "date": "2019-01-30T11:56:09", "name": "libcamera: add basic support for streams and format configuration", "version": 5, "mbox": "https://patchwork.libcamera.org/series/156/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/448/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/448/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52E5C60DB9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Jan 2019 12:56:46 +0100 (CET)", "from wyvern.c.hoisthospitality.com (unknown [217.64.245.162])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 1bdfdf0c-2486-11e9-911a-0050569116f7;\n\tWed, 30 Jan 2019 12:56:44 +0100 (CET)" ], "X-Halon-ID": "1bdfdf0c-2486-11e9-911a-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 30 Jan 2019 12:56:11 +0100", "Message-Id": "<20190130115615.17362-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190130115615.17362-1-niklas.soderlund@ragnatech.se>", "References": "<20190130115615.17362-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 2/6] libcamera: stream: add initial\n\tStreamConfiguration structure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 30 Jan 2019 11:56:46 -0000" }, "content": "Add an initial StreamConfiguration implementation to hold configuration\ndata for a single stream of a Camera. In its current form not many\nconfiguration parameters are supported but it's expected the number of\noptions will grow over time.\n\nAt this stage the pixel format is represented as an unsigned int to\nallow for easy mapping to the V4L2 API. This might be subject to change\nin the future as we finalize how libcamera shall represent pixel\nformats.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/stream.h | 6 ++++++\n src/libcamera/stream.cpp | 26 ++++++++++++++++++++++++++\n 2 files changed, 32 insertions(+)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 4f47d85ed6382b36..4b24dd841dd64b64 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -13,6 +13,12 @@ class Stream final\n {\n };\n \n+struct StreamConfiguration {\n+\tunsigned int width;\n+\tunsigned int height;\n+\tunsigned int pixelFormat;\n+};\n+\n } /* namespace libcamera */\n \n #endif /* __LIBCAMERA_STREAM_H__ */\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex f82b05a2bcfa14e9..4819cd94c1850efb 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -48,4 +48,30 @@ namespace libcamera {\n * optimal stream for the task.\n */\n \n+/**\n+ * \\struct StreamConfiguration\n+ * \\brief Configuration parameters for a stream\n+ *\n+ * The StreamConfiguration structure models all information which can be\n+ * configured for a single video stream.\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::width\n+ * \\brief Stream width in pixels\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::height\n+ * \\brief Stream height in pixels\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::pixelFormat\n+ * \\brief Stream pixel format\n+ *\n+ * This is a little endian four character code representation of the pixel\n+ * format described in V4L2 using the V4L2_PIX_FMT_* definitions.\n+ */\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v5", "2/6" ] }