Patch Detail
Show a patch.
GET /api/1.1/patches/443/?format=api
{ "id": 443, "url": "https://patchwork.libcamera.org/api/1.1/patches/443/?format=api", "web_url": "https://patchwork.libcamera.org/patch/443/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190129135357.32339-4-kieran.bingham@ideasonboard.com>", "date": "2019-01-29T13:53:56", "name": "[libcamera-devel,3/4] libcamera: buffer: Provide access to the Buffer vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "043d60740b61be9ba7834da3df2e293c1113ab0d", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/443/mbox/", "series": [ { "id": 154, "url": "https://patchwork.libcamera.org/api/1.1/series/154/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=154", "date": "2019-01-29T13:53:53", "name": "libcamera: Buffer Objects", "version": 1, "mbox": "https://patchwork.libcamera.org/series/154/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/443/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/443/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E7B260DB9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Jan 2019 14:54:02 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 409AB41;\n\tTue, 29 Jan 2019 14:54:02 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548770042;\n\tbh=khPrAXSUDdvHG6oC9UX0l6d1zbgeRJ1DZZlS0YUpEvU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=D3HtYr/OgjugldA0fpAQ2lbEd/f2grgndEmAFV/GRJOTGnugokIAjvAt3MYVNgQlk\n\tTeIq1wnbLcz8pFh4kH9RbM4Bfsm0GtyyWVibljmlG834QdKpVJoerIKsAHDlC6vSpk\n\tA9lsoXVfw3csEQmFOl/kfN7N6b23/4ChaehGXqjs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 29 Jan 2019 13:53:56 +0000", "Message-Id": "<20190129135357.32339-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20190129135357.32339-1-kieran.bingham@ideasonboard.com>", "References": "<20190129135357.32339-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] libcamera: buffer: Provide access to\n\tthe Buffer vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 29 Jan 2019 13:54:02 -0000" }, "content": "Extend the BufferPool to support retrieving Buffers by receiving a reference to\nthe buffer vector.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/buffer.h | 1 +\n src/libcamera/buffer.cpp | 5 +++++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex 97c8025d9e77..dda5075f2879 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -42,6 +42,7 @@ public:\n \tvoid free();\n \n \tunsigned int count() const { return buffers_.size(); };\n+\tconst std::vector<Buffer *> &buffers() { return buffers_; };\n \n private:\n \tvirtual int allocateMemory() = 0;\ndiff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\nindex 5c580b540a67..4a870df77e92 100644\n--- a/src/libcamera/buffer.cpp\n+++ b/src/libcamera/buffer.cpp\n@@ -141,4 +141,9 @@ void BufferPool::free()\n * \\brief Get the number of Buffers contained within this pool\n */\n \n+/**\n+ * \\fn BufferPool::buffers()\n+ * \\brief Return a reference to the vector holding all buffers within the pool\n+ */\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "3/4" ] }