Patch Detail
Show a patch.
GET /api/1.1/patches/436/?format=api
{ "id": 436, "url": "https://patchwork.libcamera.org/api/1.1/patches/436/?format=api", "web_url": "https://patchwork.libcamera.org/patch/436/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190129020048.16774-4-niklas.soderlund@ragnatech.se>", "date": "2019-01-29T02:00:45", "name": "[libcamera-devel,v4,3/6] libcamera: camera: Add acquire() and release()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b4588bd08dac6f77e2d85d1c81b9d10ff5d05674", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/436/mbox/", "series": [ { "id": 153, "url": "https://patchwork.libcamera.org/api/1.1/series/153/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=153", "date": "2019-01-29T02:00:43", "name": "libcamera: add basic support for streams and format configuration", "version": 4, "mbox": "https://patchwork.libcamera.org/series/153/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/436/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/436/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAACC60DC3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Jan 2019 03:00:58 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid b7246620-2369-11e9-874f-005056917f90;\n\tTue, 29 Jan 2019 03:00:56 +0100 (CET)" ], "X-Halon-ID": "b7246620-2369-11e9-874f-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Jan 2019 03:00:45 +0100", "Message-Id": "<20190129020048.16774-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190129020048.16774-1-niklas.soderlund@ragnatech.se>", "References": "<20190129020048.16774-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/6] libcamera: camera: Add acquire()\n\tand release()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 29 Jan 2019 02:00:59 -0000" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nExclusive access must be obtained before performing operations that\nchange the device state. Define an internal flag to track ownership and\nprovide a means of protecting functions that change device\nconfiguration.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/camera.h | 5 +++++\n src/libcamera/camera.cpp | 39 +++++++++++++++++++++++++++++++++++++-\n 2 files changed, 43 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex a2ded62de94814c4..7e358f8c0aa093cf 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -29,6 +29,9 @@ public:\n \n \tSignal<Camera *> disconnected;\n \n+\tint acquire();\n+\tvoid release();\n+\n private:\n \tCamera(PipelineHandler *pipe, const std::string &name);\n \t~Camera();\n@@ -38,6 +41,8 @@ private:\n \n \tstd::shared_ptr<PipelineHandler> pipe_;\n \tstd::string name_;\n+\n+\tbool acquired_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 9cec289282e4797b..500976b237bcbd2d 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -102,12 +102,14 @@ const std::string &Camera::name() const\n */\n \n Camera::Camera(PipelineHandler *pipe, const std::string &name)\n-\t: pipe_(pipe->shared_from_this()), name_(name)\n+\t: pipe_(pipe->shared_from_this()), name_(name), acquired_(false)\n {\n }\n \n Camera::~Camera()\n {\n+\tif (acquired_)\n+\t\tLOG(Camera, Error) << \"Removing camera while still in use\";\n }\n \n /**\n@@ -127,4 +129,39 @@ void Camera::disconnect()\n \tdisconnected.emit(this);\n }\n \n+/**\n+ * \\brief Acquire the camera device for exclusive access\n+ *\n+ * After opening the device with open(), exclusive access must be obtained\n+ * before performing operations that change the device state. This function is\n+ * not blocking, if the device has already been acquired (by the same or another\n+ * process) the -EBUSY error code is returned.\n+ *\n+ * Once exclusive access isn't needed anymore, the device should be released\n+ * with a call to the release() function.\n+ *\n+ * \\todo Implement exclusive access across processes.\n+ *\n+ * \\return 0 on success or a negative error code on error.\n+ */\n+int Camera::acquire()\n+{\n+\tif (acquired_)\n+\t\treturn -EBUSY;\n+\n+\tacquired_ = true;\n+\treturn 0;\n+}\n+\n+/**\n+ * \\brief Release exclusive access to the camera device\n+ *\n+ * Releasing the camera device allows other users to acquire exclusive access\n+ * with the acquire() function.\n+ */\n+void Camera::release()\n+{\n+\tacquired_ = false;\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v4", "3/6" ] }