Patch Detail
Show a patch.
GET /api/1.1/patches/435/?format=api
{ "id": 435, "url": "https://patchwork.libcamera.org/api/1.1/patches/435/?format=api", "web_url": "https://patchwork.libcamera.org/patch/435/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190129020048.16774-3-niklas.soderlund@ragnatech.se>", "date": "2019-01-29T02:00:44", "name": "[libcamera-devel,v4,2/6] libcamera: stream: add initial StreamConfiguration structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c81def4d90703784a939a2e8dfc5238ba274a849", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/435/mbox/", "series": [ { "id": 153, "url": "https://patchwork.libcamera.org/api/1.1/series/153/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=153", "date": "2019-01-29T02:00:43", "name": "libcamera: add basic support for streams and format configuration", "version": 4, "mbox": "https://patchwork.libcamera.org/series/153/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/435/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/435/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F08EC60C78\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Jan 2019 03:00:57 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid b6caa1e0-2369-11e9-874f-005056917f90;\n\tTue, 29 Jan 2019 03:00:55 +0100 (CET)" ], "X-Halon-ID": "b6caa1e0-2369-11e9-874f-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Jan 2019 03:00:44 +0100", "Message-Id": "<20190129020048.16774-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190129020048.16774-1-niklas.soderlund@ragnatech.se>", "References": "<20190129020048.16774-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 2/6] libcamera: stream: add initial\n\tStreamConfiguration structure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 29 Jan 2019 02:00:58 -0000" }, "content": "Add an initial StreamConfiguration implementation to hold configuration\ndata for a single stream of a Camera. In its current form not many\nconfiguration parameters are supported but it's expected the number of\noptions will grow over time.\n\nAt this stage the pixel format is represented as an unsigned int to\nallow for easy mapping to the V4L2 API. This might be subject to change\nin the future as we finalize how libcamera shall represent pixel\nformats.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/stream.h | 6 ++++++\n src/libcamera/stream.cpp | 26 ++++++++++++++++++++++++++\n 2 files changed, 32 insertions(+)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 4f47d85ed6382b36..4b24dd841dd64b64 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -13,6 +13,12 @@ class Stream final\n {\n };\n \n+struct StreamConfiguration {\n+\tunsigned int width;\n+\tunsigned int height;\n+\tunsigned int pixelFormat;\n+};\n+\n } /* namespace libcamera */\n \n #endif /* __LIBCAMERA_STREAM_H__ */\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 01f4e5008af8ac46..ef55f947574e241c 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -48,4 +48,30 @@ namespace libcamera {\n * optimal stream for the task.\n */\n \n+/**\n+ * \\struct StreamConfiguration\n+ * \\brief Configuration parameters for a stream\n+ *\n+ * The StreamConfiguration structure models all information which can be\n+ * configured for a single video stream.\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::width\n+ * \\brief Stream width in pixels\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::height\n+ * \\brief Stream height in pixels\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::pixelFormat\n+ * \\brief Stream pixel format\n+ *\n+ * This is a little endian four character code representation of the pixel\n+ * format described in V4L2 using the V4L2_PIX_FMT_* definitions.\n+ */\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v4", "2/6" ] }