Patch Detail
Show a patch.
GET /api/1.1/patches/422/?format=api
{ "id": 422, "url": "https://patchwork.libcamera.org/api/1.1/patches/422/?format=api", "web_url": "https://patchwork.libcamera.org/patch/422/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190128004109.25860-2-niklas.soderlund@ragnatech.se>", "date": "2019-01-28T00:41:04", "name": "[libcamera-devel,1/6] cam: options: move enum OptionArgument", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f3f1a54c6d43d199471e355f2f20b24dcc106b55", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/422/mbox/", "series": [ { "id": 149, "url": "https://patchwork.libcamera.org/api/1.1/series/149/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=149", "date": "2019-01-28T00:41:03", "name": "cam: add --format option to configure a stream", "version": 1, "mbox": "https://patchwork.libcamera.org/series/149/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/422/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/422/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B218360DB6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Jan 2019 01:41:32 +0100 (CET)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 65db9697-2295-11e9-911a-0050569116f7;\n\tMon, 28 Jan 2019 01:41:07 +0100 (CET)" ], "X-Halon-ID": "65db9697-2295-11e9-911a-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Jan 2019 01:41:04 +0100", "Message-Id": "<20190128004109.25860-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190128004109.25860-1-niklas.soderlund@ragnatech.se>", "References": "<20190128004109.25860-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/6] cam: options: move enum OptionArgument", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 28 Jan 2019 00:41:33 -0000" }, "content": "The enumeration of the different possibilities for arguments can be used\nby other parser then OptionsParser. Move it outside the class to make it\nready to be used by other parsers.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/main.cpp | 3 +--\n src/cam/options.h | 12 ++++++------\n 2 files changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex cb98d302dcf30331..bde47a8f17983912 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -38,8 +38,7 @@ static int parseOptions(int argc, char *argv[])\n \tOptionsParser parser;\n \n \tparser.addOption(OptCamera, \"Specify which camera to operate on\",\n-\t\t\t \"camera\", OptionsParser::ArgumentRequired,\n-\t\t\t \"camera\");\n+\t\t\t \"camera\", ArgumentRequired, \"camera\");\n \tparser.addOption(OptHelp, \"Display this help message\", \"help\");\n \tparser.addOption(OptList, \"List all cameras\", \"list\");\n \ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex f99ea7300a71c24f..491f6a316fffbe5b 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -11,15 +11,15 @@\n #include <map>\n #include <vector>\n \n+enum OptionArgument {\n+\tArgumentNone,\n+\tArgumentRequired,\n+\tArgumentOptional,\n+};\n+\n class OptionsParser\n {\n public:\n-\tenum OptionArgument {\n-\t\tArgumentNone,\n-\t\tArgumentRequired,\n-\t\tArgumentOptional,\n-\t};\n-\n \tclass Options {\n \tpublic:\n \t\tOptions();\n", "prefixes": [ "libcamera-devel", "1/6" ] }