Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4194,
    "url": "https://patchwork.libcamera.org/api/1.1/patches/4194/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/4194/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200623190836.53446-21-paul.elder@ideasonboard.com>",
    "date": "2020-06-23T19:08:34",
    "name": "[libcamera-devel,v3,20/22] v4l2: v4l2_camera_proxy: Don't allow buffers to be freed if still mmaped",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "48ec6d851d0b48b7c20c1f299ea23187a5df0f2b",
    "submitter": {
        "id": 17,
        "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api",
        "name": "Paul Elder",
        "email": "paul.elder@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/4194/mbox/",
    "series": [
        {
            "id": 1034,
            "url": "https://patchwork.libcamera.org/api/1.1/series/1034/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1034",
            "date": "2020-06-23T19:08:14",
            "name": "Support v4l2-compliance",
            "version": 3,
            "mbox": "https://patchwork.libcamera.org/series/1034/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/4194/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/4194/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<paul.elder@ideasonboard.com>",
        "Received": [
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 210D6609C6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jun 2020 21:09:50 +0200 (CEST)",
            "from jade.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:8147:f2a2:a8c6:9087])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A107E2A9;\n\tTue, 23 Jun 2020 21:09:48 +0200 (CEST)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ebzGfiRp\"; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592939389;\n\tbh=8coaori1SrU/VypE8oAgozo2o4zk4NkUTpLhVNG6EHg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ebzGfiRp0M/CmuD9iICE2ytESXq7CSXEvP9kFZoWLsJiMtCAdL+OC/ARE9MVh/WMp\n\t91guBizbg6BQ0MkllVb3W4Ve/eHqn20SdQaa9Ml1mEQkUm33Lv2NmCHzwFh6DeCOVC\n\trCjg6eXIUy5Zd7udqwKpXPF8Y5D+TFkb2bOVDiu0=",
        "From": "Paul Elder <paul.elder@ideasonboard.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Wed, 24 Jun 2020 04:08:34 +0900",
        "Message-Id": "<20200623190836.53446-21-paul.elder@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "In-Reply-To": "<20200623190836.53446-1-paul.elder@ideasonboard.com>",
        "References": "<20200623190836.53446-1-paul.elder@ideasonboard.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v3 20/22] v4l2: v4l2_camera_proxy: Don't\n\tallow buffers to be freed if still mmaped",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Tue, 23 Jun 2020 19:09:50 -0000"
    },
    "content": "In VIDIOC_REQBUFS with count = 0, if the buffers are still mmaped, they\nshould not be allowed to be freed. Add a check for this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNo change in v3\n\nNew in v2\n- split from \"Fix v4l2-compliance streaming tests\"\n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex dd09951..ce0d755 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -471,6 +471,9 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n \tmemset(arg->reserved, 0, sizeof(arg->reserved));\n \n \tif (arg->count == 0) {\n+\t\tif (!mmaps_.empty())\n+\t\t\treturn -EBUSY;\n+\n \t\tif (vcam_->isRunning())\n \t\t\treturn -EBUSY;\n \n",
    "prefixes": [
        "libcamera-devel",
        "v3",
        "20/22"
    ]
}