Patch Detail
Show a patch.
GET /api/1.1/patches/4164/?format=api
{ "id": 4164, "url": "https://patchwork.libcamera.org/api/1.1/patches/4164/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4164/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200623164911.45147-2-jacopo@jmondi.org>", "date": "2020-06-23T16:49:09", "name": "[libcamera-devel,17/25] media: ov5647: Rename SBGGR8 VGA mode", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "3abcbdf4a58ab5923505af3d7cab3f6ee355895f", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/4164/mbox/", "series": [ { "id": 1030, "url": "https://patchwork.libcamera.org/api/1.1/series/1030/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1030", "date": "2020-06-23T10:07:50", "name": "media: ov5647: Support RaspberryPi Camera Module v1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1030/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4164/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4164/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D93D60103\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Jun 2020 18:46:17 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 1867C100007;\n\tTue, 23 Jun 2020 16:46:13 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "mchehab@kernel.org, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl,\n\tlaurent.pinchart@ideasonboard.com, roman.kovalivskyi@globallogic.com, \n\tdave.stevenson@raspberrypi.org, naush@raspberrypi.com", "Cc": "mrodin@de.adit-jv.com, hugues.fruchet@st.com, mripard@kernel.org,\n\taford173@gmail.com, sudipi@jp.adit-jv.com, andrew_gabbasov@mentor.com,\n\terosca@de.adit-jv.com, linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org, Jacopo Mondi <jacopo@jmondi.org>", "Date": "Tue, 23 Jun 2020 18:49:09 +0200", "Message-Id": "<20200623164911.45147-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200623100815.10674-1-jacopo@jmondi.org>", "References": "<20200623100815.10674-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 17/25] media: ov5647: Rename SBGGR8 VGA\n\tmode", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 23 Jun 2020 16:46:17 -0000" }, "content": "Before adding new modes, rename the only existing one to report\nthe media bus format in the name to distinguish it from future\nadditions.\n\nWhile at it, briefly describe the mode.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n drivers/media/i2c/ov5647.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c\nindex 3757f0b10fe93..c36d6b92b97a0 100644\n--- a/drivers/media/i2c/ov5647.c\n+++ b/drivers/media/i2c/ov5647.c\n@@ -115,7 +115,7 @@ static struct regval_list sensor_oe_enable_regs[] = {\n \t{0x3002, 0xe4},\n };\n \n-static struct regval_list ov5647_640x480[] = {\n+static struct regval_list ov5647_640x480_sbggr8[] = {\n \t{0x0100, 0x00},\n \t{0x0103, 0x01},\n \t{0x3034, 0x08},\n@@ -205,7 +205,8 @@ static struct regval_list ov5647_640x480[] = {\n \t{0x0100, 0x01},\n };\n \n-static struct ov5647_mode ov5647_8bit_modes[] = {\n+static struct ov5647_mode ov5647_sbggr8_modes[] = {\n+\t/* 8-bit VGA mode: Uncentred crop 2x2 binned 1296x972 image. */\n \t{\n \t\t.format\t= {\n \t\t\t.code\t\t= MEDIA_BUS_FMT_SBGGR8_1X8,\n@@ -220,16 +221,16 @@ static struct ov5647_mode ov5647_8bit_modes[] = {\n \t\t\t.width\t\t= 1280,\n \t\t\t.height\t\t= 960,\n \t\t},\n-\t\t.reg_list\t= ov5647_640x480,\n-\t\t.num_regs\t= ARRAY_SIZE(ov5647_640x480)\n+\t\t.reg_list\t= ov5647_640x480_sbggr8,\n+\t\t.num_regs\t= ARRAY_SIZE(ov5647_640x480_sbggr8)\n \t},\n };\n \n static const struct ov5647_format_list ov5647_formats[] = {\n \t{\n \t\t.mbus_code\t= MEDIA_BUS_FMT_SBGGR8_1X8,\n-\t\t.modes\t\t= ov5647_8bit_modes,\n-\t\t.num_modes\t= ARRAY_SIZE(ov5647_8bit_modes),\n+\t\t.modes\t\t= ov5647_sbggr8_modes,\n+\t\t.num_modes\t= ARRAY_SIZE(ov5647_sbggr8_modes),\n \t},\n };\n \n", "prefixes": [ "libcamera-devel", "17/25" ] }