Patch Detail
Show a patch.
GET /api/1.1/patches/4112/?format=api
{ "id": 4112, "url": "https://patchwork.libcamera.org/api/1.1/patches/4112/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4112/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200622135550.10788-5-david.plowman@raspberrypi.com>", "date": "2020-06-22T13:55:50", "name": "[libcamera-devel,v2,4/4] libcamera: ipa: raspberrypi: plumb the libcamera sharpness control through to the Raspberry Pi implementation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2e889b40d242e3f6b0f9e591095ea039fd384489", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4112/mbox/", "series": [ { "id": 1024, "url": "https://patchwork.libcamera.org/api/1.1/series/1024/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1024", "date": "2020-06-22T13:55:46", "name": "libcamera sharpness strength control", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1024/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4112/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4112/checks/", "tags": {}, "headers": { "Return-Path": "<david.plowman@raspberrypi.com>", "Received": [ "from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F761603BD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jun 2020 15:56:09 +0200 (CEST)", "by mail-wm1-x341.google.com with SMTP id g10so14966804wmh.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jun 2020 06:56:09 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tc201sm12742903wmd.4.2020.06.22.06.56.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Jun 2020 06:56:05 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"fs9O5tZj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=szZXl6QaV/4cRk25Zk5zyFZjAjLl0G9Vvu2sYyyNpS8=;\n\tb=fs9O5tZjswV2KulfyIakCXvAtpkbdAe6zWCvrVTrC8kPT84YTsychzxU/4k7+z9KjH\n\t8rI0vkmU/dNKUlBE4iRrymP8CbxMAFyo00FFl62RQllrV8ucxQ4rRAoM6aMTlsjgKmPA\n\tWq1oeXHHsytiRp0DxlTlf4vhHw9bgDQ1310PX9iYF6QSIDn3SyZvi1TfA5EUJBXgjQOu\n\tJBY8XEVYTU0c6M8wwvqKAhqaFSAiDRDxTbpQZJYQruf6luofNbY8WEh2oVE/SVsV7hdL\n\ttsZ0a/yiamNcpXxIbSznn+fid8o+yciAEvUu7q+ScTWyyW5WLrwF3J684wyBg9CwA4AM\n\t0PNA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=szZXl6QaV/4cRk25Zk5zyFZjAjLl0G9Vvu2sYyyNpS8=;\n\tb=tehJF6X2/bEVHpmsmyjYvrW2eKTgDyd120kzhxHFe3camGuA8VK2TncNytviriKMid\n\tuA2cmBMOvRZ8dkl7hdryCTCGwznybssKIJnjMe/pjq0kwWw949e2chIigr7fx4Utl3Q5\n\tn8HxtsLnsl1xr+TJ5vyasAw36pXvQ2RLMvtdbcjxugcHiKMMiF/tfi1Cb7QR2fv0BIgt\n\twr3qKBD5Em177KE8v2RfP+Q4yqI6ZIbPYdyIWEx8vDVAf7i38fPPusxshF7kJ84ga9WK\n\tcOr4KaisnoOD09gm/AytkmUrxfkOppjJOHIkyrLW9Cguhv6L7VGEnhtaa5JEhdXAFsfT\n\tGImw==", "X-Gm-Message-State": "AOAM530nmwBBGOM368uCaybYTWA0tLwyqi4pxTtNcdRtGyunCxMyBTL3\n\thjFJN60WaE02rkCSGdzkG3Ii/OcRrCI=", "X-Google-Smtp-Source": "ABdhPJwtiuzpeKl1qCe3J2ISQR5vI8wMxYiSEgv7vMAjqqwz2OEMgSBHnkpmCaZsSfTJiI24rs/JZA==", "X-Received": "by 2002:a1c:4343:: with SMTP id q64mr7104104wma.20.1592834165686;\n\tMon, 22 Jun 2020 06:56:05 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 22 Jun 2020 14:55:50 +0100", "Message-Id": "<20200622135550.10788-5-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200622135550.10788-1-david.plowman@raspberrypi.com>", "References": "<20200622135550.10788-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/4] libcamera: ipa: raspberrypi: plumb\n\tthe libcamera sharpness control through to the Raspberry Pi\n\timplementation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 22 Jun 2020 13:56:09 -0000" }, "content": "This simply wires up the libcamera sharpness control in the Raspberry\nPi IPAs so that it controls the strength of the Raspberry Pi sharpness\ncontrol algorithm.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n include/libcamera/ipa/raspberrypi.h | 1 +\n src/ipa/raspberrypi/raspberrypi.cpp | 12 ++++++++++++\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex c109469..a18ce9a 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -51,6 +51,7 @@ static const ControlInfoMap RPiControls = {\n \t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n \t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n+\t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 42c84b1..bc89ab5 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -47,6 +47,7 @@\n #include \"metadata.hpp\"\n #include \"noise_status.h\"\n #include \"sdn_status.h\"\n+#include \"sharpen_algorithm.hpp\"\n #include \"sharpen_status.h\"\n \n namespace libcamera {\n@@ -633,6 +634,17 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\tbreak;\n \t\t}\n \n+\t\tcase controls::SHARPNESS: {\n+\t\t\tRPi::SharpenAlgorithm *sharpen = dynamic_cast<RPi::SharpenAlgorithm *>(\n+\t\t\t\tcontroller_.GetAlgorithm(\"sharpen\"));\n+\t\t\tASSERT(sharpen);\n+\n+\t\t\tsharpen->SetStrength(ctrl.second.get<float>());\n+\t\t\tlibcameraMetadata_.set(controls::Sharpness,\n+\t\t\t\t\t ctrl.second.get<float>());\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tdefault:\n \t\t\tLOG(IPARPI, Warning)\n \t\t\t\t<< \"Ctrl \" << controls::controls.at(ctrl.first)->name()\n", "prefixes": [ "libcamera-devel", "v2", "4/4" ] }