Patch Detail
Show a patch.
GET /api/1.1/patches/4110/?format=api
{ "id": 4110, "url": "https://patchwork.libcamera.org/api/1.1/patches/4110/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4110/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200622135550.10788-3-david.plowman@raspberrypi.com>", "date": "2020-06-22T13:55:48", "name": "[libcamera-devel,v2,2/4] libcamera: ipa: raspberrypi: make sharpening mode_factor an ordinary double", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "69cc99340d6deab89b7a0a81830fa9ef42fe9061", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4110/mbox/", "series": [ { "id": 1024, "url": "https://patchwork.libcamera.org/api/1.1/series/1024/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1024", "date": "2020-06-22T13:55:46", "name": "libcamera sharpness strength control", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1024/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4110/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4110/checks/", "tags": {}, "headers": { "Return-Path": "<david.plowman@raspberrypi.com>", "Received": [ "from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D1D1609A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jun 2020 15:56:02 +0200 (CEST)", "by mail-wr1-x429.google.com with SMTP id v3so9295489wrc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jun 2020 06:56:02 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tc201sm12742903wmd.4.2020.06.22.06.56.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Jun 2020 06:56:01 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"C3f6E5ky\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=blzNJOKYHnrUW4DxPt8nCOhq186OUDTiJdxCE82eKU0=;\n\tb=C3f6E5kyzGuCh2jEeLZGQZ8s3URPOGdqmUmrUkIUN6+zU6CnHuvwgIqdBHjDNdw6Bj\n\txF0lictHjyS/1ajVmU4JiNh4UW3nbaKrBH1a9figrLuR+41ikHgvyo7U/TsJWi8DVMhj\n\tTOoqTK+X3oAeEEwbn1EKyiMJmOVyJ+x8+nutE4sNaAkc+3fKvyOCAigfej8yzJya/k51\n\t441sCSpvQqQmrVWSPcjtVgfbjRwBrJdpIg8k/JqUfG7nWNYwf68Xvz4D9SqpILoBmjo5\n\tHo83qH5du+t0Z9ofXhemcxZ3bOkoe+ArPVGk477l3kvfkTbVdGhvD9t+YXbi5+UUwIMx\n\teUWw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=blzNJOKYHnrUW4DxPt8nCOhq186OUDTiJdxCE82eKU0=;\n\tb=HZ4gjwXhpbjAqmacGcPsricQ3sKfzYbyMomJ9vBj/JRBhxMXGqydwUUxEwPluLfMCN\n\tN/N14xuQU0P1ZqIbWF0KxFhHqQWKGwQmxsiloo166csei3XZOZIGq5pmWRm3U0HVSFoJ\n\tlqoLVXov3rO0nHqFQYJSFFErqLTBvptr9TPlXpRciq3m+1Qmz4IgNx+OJMiq3V+7+dBi\n\tHBKADPXeJj7W4MpBPFswhRf5MGYlJT870ocSxkfvQBKVoidB+UP7polS9M9LZqtKv4Cc\n\thn9L/tm1efp83j/cUGwupvED55j+M/4WA4unwSMCrdqUzTZ9+ag0Ct5+bCTZnMnPsc1b\n\tTkRA==", "X-Gm-Message-State": "AOAM532Ygu88BQHr4UfpuZL2GvsyKXmQ8raGvjm/ivuicauwWvNEUbKM\n\ttg88K6vSN+hVo/veUeJQwD+2+DuL/7o=", "X-Google-Smtp-Source": "ABdhPJxIBzk1eV2arJ/9xuLKMRKccUVIgZ9jmT98ImGVBuoSI7I50WycgKGL699A+7thK8jhuOs5Ww==", "X-Received": "by 2002:a05:6000:128c:: with SMTP id\n\tf12mr7315068wrx.67.1592834161664; \n\tMon, 22 Jun 2020 06:56:01 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 22 Jun 2020 14:55:48 +0100", "Message-Id": "<20200622135550.10788-3-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200622135550.10788-1-david.plowman@raspberrypi.com>", "References": "<20200622135550.10788-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/4] libcamera: ipa: raspberrypi: make\n\tsharpening mode_factor an ordinary double", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 22 Jun 2020 13:56:02 -0000" }, "content": "No need for it to be std::atomic as SwitchMode runs synchronously with\nPrepare.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/sharpen.cpp | 7 +++----\n src/ipa/raspberrypi/controller/rpi/sharpen.hpp | 2 +-\n 2 files changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\nindex 086952f..4c2fdb3 100644\n--- a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n@@ -44,13 +44,12 @@ void Sharpen::Read(boost::property_tree::ptree const ¶ms)\n \n void Sharpen::Prepare(Metadata *image_metadata)\n {\n-\tdouble mode_factor = mode_factor_;\n \tstruct SharpenStatus status;\n \t// Binned modes seem to need the sharpening toned down with this\n \t// pipeline.\n-\tstatus.threshold = threshold_ * mode_factor;\n-\tstatus.strength = strength_ / mode_factor;\n-\tstatus.limit = limit_ / mode_factor;\n+\tstatus.threshold = threshold_ * mode_factor_;\n+\tstatus.strength = strength_ / mode_factor_;\n+\tstatus.limit = limit_ / mode_factor_;\n \timage_metadata->Set(\"sharpen.status\", status);\n }\n \ndiff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.hpp b/src/ipa/raspberrypi/controller/rpi/sharpen.hpp\nindex f871aa6..a3bf899 100644\n--- a/src/ipa/raspberrypi/controller/rpi/sharpen.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/sharpen.hpp\n@@ -26,7 +26,7 @@ private:\n \tdouble threshold_;\n \tdouble strength_;\n \tdouble limit_;\n-\tstd::atomic<double> mode_factor_;\n+\tdouble mode_factor_;\n };\n \n } // namespace RPi\n", "prefixes": [ "libcamera-devel", "v2", "2/4" ] }