Patch Detail
Show a patch.
GET /api/1.1/patches/4105/?format=api
{ "id": 4105, "url": "https://patchwork.libcamera.org/api/1.1/patches/4105/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4105/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200622043812.16989-1-laurent.pinchart@ideasonboard.com>", "date": "2020-06-22T04:38:12", "name": "[libcamera-devel,v2] libcamera: add support for planar YUV422 and YUV420 formats", "commit_ref": "c3ed943c992a09c5fc19e25328dca7aa52691c36", "pull_url": null, "state": "accepted", "archived": false, "hash": "3ed81f488524a747a027981c7a33d20087f614d0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4105/mbox/", "series": [ { "id": 1021, "url": "https://patchwork.libcamera.org/api/1.1/series/1021/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1021", "date": "2020-06-22T04:38:12", "name": "[libcamera-devel,v2] libcamera: add support for planar YUV422 and YUV420 formats", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1021/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4105/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4105/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA19603BC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Jun 2020 06:38:41 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACD5A30D;\n\tMon, 22 Jun 2020 06:38:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LaKdDRJf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592800720;\n\tbh=ZcBHorP7XCD8/kiPNjRmi7ioc5TAlfBf9l4HH+OC8vE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=LaKdDRJf+RtCglUiUeja2+vwogg2JVYeZpkNlr7BpvWTcHO59RCjCFb0azLwXSgE1\n\tXghdp1s+N2k8lLt/iGSna91KbFWuJHU+c7XwIICxj5sxJ6e7IeNkdKBGCqmzgyh8qA\n\tr5tBsDYN0Osi0lu6JDzMO0q3UUBdfboL3jx4mXZc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 22 Jun 2020 07:38:12 +0300", "Message-Id": "<20200622043812.16989-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libcamera: add support for planar\n\tYUV422 and YUV420 formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 22 Jun 2020 04:38:41 -0000" }, "content": "From: David Plowman <david.plowman@raspberrypi.com>\n\nThese formats can be helpful when downstream applications or libraries\nsupport them natively (avoiding a costly conversion).\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v1:\n\n- Rebase on top of formats rework\n- Fix number of planes in formats descriptions\n---\n src/libcamera/formats.cpp | 14 ++++++++++++++\n src/libcamera/formats.yaml | 5 +++++\n src/libcamera/v4l2_pixelformat.cpp | 2 ++\n src/v4l2/v4l2_camera_proxy.cpp | 4 +++-\n 4 files changed, 24 insertions(+), 1 deletion(-)\n\nDavid, could you please test this and provide a Tested-by tag (and\nReviewed-by too if possible) ?", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 97e986786cc8..c0b53ce7cc97 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -270,6 +270,20 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n \t} },\n+\t{ formats::YUV420, {\n+\t\t.format = PixelFormat(formats::YUV420),\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV420),\n+\t\t.bitsPerPixel = 12,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t} },\n+\t{ formats::YUV422, {\n+\t\t.format = PixelFormat(formats::YUV422),\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV422P),\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = false,\n+\t} },\n \n \t/* Greyscale formats. */\n \t{ formats::R8, {\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex a6841c618f93..ce06dbc41aa1 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -53,6 +53,11 @@ formats:\n - NV42:\n fourcc: DRM_FORMAT_NV42\n \n+ - YUV420:\n+ fourcc: DRM_FORMAT_YUV420\n+ - YUV422:\n+ fourcc: DRM_FORMAT_YUV422\n+\n - MJPEG:\n fourcc: DRM_FORMAT_MJPEG\n \ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 741f6c2646bc..6745d17d4926 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -63,6 +63,8 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV61), formats::NV61 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV12), formats::NV12 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV21), formats::NV21 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV420), formats::YUV420 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV422P), formats::YUV422 },\n \n \t/* Greyscale formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_GREY), formats::R8 },\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex bf47aa7ee633..86b87e379b98 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -560,7 +560,7 @@ struct PixelFormatInfo {\n \n namespace {\n \n-static const std::array<PixelFormatInfo, 14> pixelFormatInfo = {{\n+static const std::array<PixelFormatInfo, 16> pixelFormatInfo = {{\n \t/* RGB formats. */\n \t{ formats::RGB888,\tV4L2_PIX_FMT_BGR24,\t1, {{ { 24, 1, 1 }, { 0, 0, 0 }, { 0, 0, 0 } }} },\n \t{ formats::BGR888,\tV4L2_PIX_FMT_RGB24,\t1, {{ { 24, 1, 1 }, { 0, 0, 0 }, { 0, 0, 0 } }} },\n@@ -577,6 +577,8 @@ static const std::array<PixelFormatInfo, 14> pixelFormatInfo = {{\n \t{ formats::NV61,\tV4L2_PIX_FMT_NV61,\t2, {{ { 8, 1, 1 }, { 16, 2, 1 }, { 0, 0, 0 } }} },\n \t{ formats::NV24,\tV4L2_PIX_FMT_NV24,\t2, {{ { 8, 1, 1 }, { 16, 1, 1 }, { 0, 0, 0 } }} },\n \t{ formats::NV42,\tV4L2_PIX_FMT_NV42,\t2, {{ { 8, 1, 1 }, { 16, 1, 1 }, { 0, 0, 0 } }} },\n+\t{ formats::YUV420,\tV4L2_PIX_FMT_YUV420,\t3, {{ { 8, 1, 1 }, { 8, 2, 2 }, { 8, 2, 2 } }} },\n+\t{ formats::YUV422,\tV4L2_PIX_FMT_YUV422P,\t3, {{ { 8, 1, 1 }, { 8, 2, 1 }, { 8, 2, 1 } }} },\n \t/* Compressed formats. */\n \t/*\n \t * \\todo Get a better image size estimate for MJPEG, via\n", "prefixes": [ "libcamera-devel", "v2" ] }