Patch Detail
Show a patch.
GET /api/1.1/patches/4101/?format=api
{ "id": 4101, "url": "https://patchwork.libcamera.org/api/1.1/patches/4101/?format=api", "web_url": "https://patchwork.libcamera.org/patch/4101/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200619092725.19109-4-david.plowman@raspberrypi.com>", "date": "2020-06-19T09:27:25", "name": "[libcamera-devel,3/3] libcamera: raspberrypi: plumb the libcamera sharpness control through to the Raspberry Pi implementation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2e889b40d242e3f6b0f9e591095ea039fd384489", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/4101/mbox/", "series": [ { "id": 1018, "url": "https://patchwork.libcamera.org/api/1.1/series/1018/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1018", "date": "2020-06-19T09:27:22", "name": "libcamera sharpness strength control", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1018/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/4101/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/4101/checks/", "tags": {}, "headers": { "Return-Path": "<david.plowman@raspberrypi.com>", "Received": [ "from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03BCA609C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Jun 2020 11:27:55 +0200 (CEST)", "by mail-wm1-x343.google.com with SMTP id r9so7802070wmh.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Jun 2020 02:27:55 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tn65sm5156154wmf.47.2020.06.19.02.27.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 19 Jun 2020 02:27:54 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"k8F9rQuJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=al417ZoyvhZTJN/nkNKL4b92jhJkUbp6nCYhmxuDiBU=;\n\tb=k8F9rQuJMrQzQCWDeOUrP8Izs1G8Nvi3UW9Nxrhyrf/5Ni/5X4oqvz+ixqLzZgjzLE\n\tlXd5IQiQaeguxDTvNo9VhJ+dAQfL/gwAlkiOcA68afTMm33qmXnzGlahuHjCBjWaswqN\n\txeoB8QDcaqSDcL2VVKYFfscvSdV0Bdswds+Dk+AixQ+ios43PKDj51tnQ23Z8zgHEjdY\n\tl11nw8CEdvIEPD/30opATqoIPtQd5Xfx6pC+yn70ott6cRxUGJzMf+Xgv5eYROiJ48W8\n\tgGZK6ArP/Qc3W3fhU6slgmmOwJlmnPA8ZANApPw3kT6LAqLHrj5MY8LS9fKH+kCXsUuJ\n\tHurQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=al417ZoyvhZTJN/nkNKL4b92jhJkUbp6nCYhmxuDiBU=;\n\tb=N6l3FRzmplEQW+Z63WHBgZDavTZvzqWXMNRZUZ0CVkgOGUuuhx0VfB/9gPq7deJlSq\n\tZOdXLdOifE5jCGw7GvFy3HIePU39PGh0H2YWXvARgpwTf6cepr2O5jOZGwCHRnyeFMDv\n\ttiNeqEH2djLo3TZq41W0pZlCARd7DPwwpvSZpFjq3+qYdqVO4rTdHwefdSN8RoX7MoM4\n\t2TTIg//UpF3/GMgs2rTJIl9CgAVaWK91PEn9GveRbBIB3424zYH3lQ3hE8jGYm/cTEgI\n\tk4CECq3uZIRG0vWmlDpLovbVVJoASdeYeauEKBNzW6crb0FCjhDo5CYMhkwemuZPaq41\n\tnFdA==", "X-Gm-Message-State": "AOAM530NqypvYXnEhLKbB4ctB4fNm1A85z8j1kjHYKawRerYYhezw+3v\n\t8o6B/HaLUfs3z8I8wz2hulT6kESldec=", "X-Google-Smtp-Source": "ABdhPJyJUNGanz5IlgbPck55QxtYl6BY3qD0FWkwz5iX0RJW0iUeV7BQs7yJyUPYMgP8xADYsTMUzg==", "X-Received": "by 2002:a1c:cc07:: with SMTP id h7mr2734941wmb.179.1592558874387;\n\tFri, 19 Jun 2020 02:27:54 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Jun 2020 10:27:25 +0100", "Message-Id": "<20200619092725.19109-4-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200619092725.19109-1-david.plowman@raspberrypi.com>", "References": "<20200619092725.19109-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: raspberrypi: plumb the\n\tlibcamera sharpness control through to the Raspberry Pi\n\timplementation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 19 Jun 2020 09:27:55 -0000" }, "content": "This simply wires up the libcamera sharpness control in the Raspberry\nPi IPAs so that it controls the strength of the Raspberry Pi sharpness\ncontrol algorithm.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n include/libcamera/ipa/raspberrypi.h | 1 +\n src/ipa/raspberrypi/raspberrypi.cpp | 12 ++++++++++++\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex c109469..a18ce9a 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -51,6 +51,7 @@ static const ControlInfoMap RPiControls = {\n \t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n \t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n+\t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 9669f21..2f2550e 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -47,6 +47,7 @@\n #include \"metadata.hpp\"\n #include \"noise_status.h\"\n #include \"sdn_status.h\"\n+#include \"sharpen_algorithm.hpp\"\n #include \"sharpen_status.h\"\n \n namespace libcamera {\n@@ -631,6 +632,17 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\tbreak;\n \t\t}\n \n+\t\tcase controls::SHARPNESS: {\n+\t\t\tRPi::SharpenAlgorithm *sharpen = dynamic_cast<RPi::SharpenAlgorithm *>(\n+\t\t\t\tcontroller_.GetAlgorithm(\"sharpen\"));\n+\t\t\tASSERT(sharpen);\n+\n+\t\t\tsharpen->SetStrength(ctrl.second.get<float>());\n+\t\t\tlibcameraMetadata_.set(controls::Sharpness,\n+\t\t\t\t\t ctrl.second.get<float>());\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tdefault:\n \t\t\tLOG(IPARPI, Warning)\n \t\t\t\t<< \"Ctrl \" << controls::controls.at(ctrl.first)->name()\n", "prefixes": [ "libcamera-devel", "3/3" ] }