Patch Detail
Show a patch.
GET /api/1.1/patches/3996/?format=api
{ "id": 3996, "url": "https://patchwork.libcamera.org/api/1.1/patches/3996/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3996/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200608232844.10150-2-jacopo@jmondi.org>", "date": "2020-06-08T23:28:39", "name": "[libcamera-devel,v2,1/6] libcamera: formats: Make ImageFormats a templated class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "263565e00f06013136d3715fbfae23bb83ea56d8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/3996/mbox/", "series": [ { "id": 979, "url": "https://patchwork.libcamera.org/api/1.1/series/979/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=979", "date": "2020-06-08T23:28:38", "name": "ImageFormats, you again", "version": 2, "mbox": "https://patchwork.libcamera.org/series/979/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3996/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3996/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BB8D61687\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Jun 2020 01:25:25 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 891F0240004;\n\tMon, 8 Jun 2020 23:25:24 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 9 Jun 2020 01:28:39 +0200", "Message-Id": "<20200608232844.10150-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200608232844.10150-1-jacopo@jmondi.org>", "References": "<20200608232844.10150-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/6] libcamera: formats: Make\n\tImageFormats a templated class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 08 Jun 2020 23:25:25 -0000" }, "content": "The ImageFormats class was originally designed to be used by both\nV4L2VideoDevices and V4L2Subdevices. As video devices enumerates their\nimage formats using V4L2PixelFormat instances, the ImageFormats class\ncannot be used there anymore and it has been replaced by raw maps.\n\nPrepare to re-introduce usage of ImageFormats in the V4L2VideoDevice\nclass and its users by making ImageFormats a templated class that\nindexes the image sizes using on keys of variadic type.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/internal/camera_sensor.h | 2 +-\n include/libcamera/internal/formats.h | 11 ++++-----\n include/libcamera/internal/v4l2_subdevice.h | 2 +-\n src/libcamera/formats.cpp | 25 +++++++++++++--------\n src/libcamera/v4l2_subdevice.cpp | 6 ++---\n test/v4l2_subdevice/list_formats.cpp | 2 +-\n 6 files changed, 28 insertions(+), 20 deletions(-)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 7f07413f9560..d5814a26a121 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -75,7 +75,7 @@ private:\n \n \tstd::string model_;\n \n-\tImageFormats formats_;\n+\tImageFormats<uint32_t> formats_;\n \tSize resolution_;\n \tstd::vector<unsigned int> mbusCodes_;\n \tstd::vector<Size> sizes_;\ndiff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex 4b172efc6588..5668f3744c5d 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -18,18 +18,19 @@\n \n namespace libcamera {\n \n+template<typename T>\n class ImageFormats\n {\n public:\n-\tint addFormat(unsigned int format, const std::vector<SizeRange> &sizes);\n+\tint addFormat(T format, const std::vector<SizeRange> &sizes);\n \n \tbool isEmpty() const;\n-\tstd::vector<unsigned int> formats() const;\n-\tconst std::vector<SizeRange> &sizes(unsigned int format) const;\n-\tconst std::map<unsigned int, std::vector<SizeRange>> &data() const;\n+\tstd::vector<T> formats() const;\n+\tconst std::vector<SizeRange> &sizes(T format) const;\n+\tconst std::map<T, std::vector<SizeRange>> &data() const;\n \n private:\n-\tstd::map<unsigned int, std::vector<SizeRange>> data_;\n+\tstd::map<T, std::vector<SizeRange>> data_;\n };\n \n class PixelFormatInfo\ndiff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex a3ecf123f640..f811d316dada 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -51,7 +51,7 @@ public:\n \tint setSelection(unsigned int pad, unsigned int target,\n \t\t\t Rectangle *rect);\n \n-\tImageFormats formats(unsigned int pad);\n+\tImageFormats<uint32_t> formats(unsigned int pad);\n \n \tint getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \t\t Whence whence = ActiveFormat);\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 2ac3b412ecdb..62fd46686d7d 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -28,9 +28,8 @@ LOG_DEFINE_CATEGORY(Formats)\n * corresponding set of image sizes. It is used to describe the formats and\n * sizes supported by a V4L2Device or V4L2Subdevice.\n *\n- * Formats are stored as an integer. When used for a V4L2Device, the image\n- * formats are fourcc pixel formats. When used for a V4L2Subdevice they are\n- * media bus codes. Both are defined by the V4L2 specification.\n+ * When used for a V4L2Device, the image formats are V4L2PixelFormat instances.\n+ * When used for a V4L2Subdevice formats are uint32_t media bus codes.\n *\n * Sizes are stored as a list of SizeRange.\n */\n@@ -43,7 +42,8 @@ LOG_DEFINE_CATEGORY(Formats)\n * \\return 0 on success or a negative error code otherwise\n * \\retval -EEXIST The format is already described\n */\n-int ImageFormats::addFormat(unsigned int format, const std::vector<SizeRange> &sizes)\n+template<typename T>\n+int ImageFormats<T>::addFormat(T format, const std::vector<SizeRange> &sizes)\n {\n \tif (data_.find(format) != data_.end())\n \t\treturn -EEXIST;\n@@ -57,7 +57,8 @@ int ImageFormats::addFormat(unsigned int format, const std::vector<SizeRange> &s\n * \\brief Check if the list of devices supported formats is empty\n * \\return True if the list of supported formats is empty\n */\n-bool ImageFormats::isEmpty() const\n+template<typename T>\n+bool ImageFormats<T>::isEmpty() const\n {\n \treturn data_.empty();\n }\n@@ -66,9 +67,10 @@ bool ImageFormats::isEmpty() const\n * \\brief Retrieve a list of all supported image formats\n * \\return List of pixel formats or media bus codes\n */\n-std::vector<unsigned int> ImageFormats::formats() const\n+template<typename T>\n+std::vector<T> ImageFormats<T>::formats() const\n {\n-\tstd::vector<unsigned int> formats;\n+\tstd::vector<T> formats;\n \tformats.reserve(data_.size());\n \n \t/* \\todo: Should this be cached instead of computed each time? */\n@@ -88,7 +90,8 @@ std::vector<unsigned int> ImageFormats::formats() const\n * \\return The list of image sizes supported for \\a format, or an empty list if\n * the format is not supported\n */\n-const std::vector<SizeRange> &ImageFormats::sizes(unsigned int format) const\n+template<typename T>\n+const std::vector<SizeRange> &ImageFormats<T>::sizes(T format) const\n {\n \tstatic const std::vector<SizeRange> empty;\n \n@@ -103,11 +106,15 @@ const std::vector<SizeRange> &ImageFormats::sizes(unsigned int format) const\n * \\brief Retrieve the map that associates formats to image sizes\n * \\return The map that associates formats to image sizes\n */\n-const std::map<unsigned int, std::vector<SizeRange>> &ImageFormats::data() const\n+template<typename T>\n+const std::map<T, std::vector<SizeRange>> &ImageFormats<T>::data() const\n {\n \treturn data_;\n }\n \n+template class ImageFormats<uint32_t>;\n+template class ImageFormats<V4L2PixelFormat>;\n+\n /**\n * \\class PixelFormatInfo\n * \\brief Information about pixel formats\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 7aefc1be032d..9fa20e84a904 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -320,16 +320,16 @@ int V4L2Subdevice::setSelection(unsigned int pad, unsigned int target,\n *\n * \\return A list of the supported device formats\n */\n-ImageFormats V4L2Subdevice::formats(unsigned int pad)\n+ImageFormats<uint32_t> V4L2Subdevice::formats(unsigned int pad)\n {\n-\tImageFormats formats;\n+\tImageFormats<uint32_t> formats;\n \n \tif (pad >= entity_->pads().size()) {\n \t\tLOG(V4L2, Error) << \"Invalid pad: \" << pad;\n \t\treturn {};\n \t}\n \n-\tfor (unsigned int code : enumPadCodes(pad)) {\n+\tfor (uint32_t code : enumPadCodes(pad)) {\n \t\tstd::vector<SizeRange> sizes = enumPadSizes(pad, code);\n \t\tif (sizes.empty())\n \t\t\treturn {};\ndiff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\nindex a55af1100d9a..3e8d4cdba045 100644\n--- a/test/v4l2_subdevice/list_formats.cpp\n+++ b/test/v4l2_subdevice/list_formats.cpp\n@@ -47,7 +47,7 @@ void ListFormatsTest::printFormats(unsigned int pad,\n int ListFormatsTest::run()\n {\n \t/* List all formats available on existing \"Scaler\" pads. */\n-\tImageFormats formats;\n+\tImageFormats<uint32_t> formats;\n \n \tformats = scaler_->formats(0);\n \tif (formats.isEmpty()) {\n", "prefixes": [ "libcamera-devel", "v2", "1/6" ] }