Patch Detail
Show a patch.
GET /api/1.1/patches/3910/?format=api
{ "id": 3910, "url": "https://patchwork.libcamera.org/api/1.1/patches/3910/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3910/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200604004106.7240-1-laurent.pinchart@ideasonboard.com>", "date": "2020-06-04T00:41:06", "name": "[libcamera-devel] libcamera: Mark logPrefix() implementations with override", "commit_ref": "f1cac536f40fca701aa3ba4fe19d2f326c8bcc8e", "pull_url": null, "state": "accepted", "archived": false, "hash": "21f1344a40e9b24eae57c791b1f2a16b5ecfb432", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3910/mbox/", "series": [ { "id": 947, "url": "https://patchwork.libcamera.org/api/1.1/series/947/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=947", "date": "2020-06-04T00:41:06", "name": "[libcamera-devel] libcamera: Mark logPrefix() implementations with override", "version": 1, "mbox": "https://patchwork.libcamera.org/series/947/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3910/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3910/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56E2A61012\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jun 2020 02:41:27 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE95F29B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jun 2020 02:41:26 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HqVEvlu5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591231287;\n\tbh=b6nk+/zBqzwR2XVGjpvGdQVT7JXTE1fKggl30/UPtVo=;\n\th=From:To:Subject:Date:From;\n\tb=HqVEvlu5DJbd4FRJhz1iLZIzvlEH81dRkJFsGfQYCsSQY2IJji4XaXZDzc6QMUIpN\n\tni1rQPzIec6uDcAfPWo81KQ8cYmbi3DgVKTD6LF+V6OvHTJz1Je0km4FHU3soDexPM\n\tCU0bvHJtN9hpMIhmUMfTh3L3Td5XfiqvBCIRDW54=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Jun 2020 03:41:06 +0300", "Message-Id": "<20200604004106.7240-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Mark logPrefix()\n\timplementations with override", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 04 Jun 2020 00:41:27 -0000" }, "content": "Virtual functions overriden in derived classes should be marked with the\noverride keyword. Do so for the logPrefix() implementations inheriting\nfrom the Loggable class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/camera_sensor.h | 2 +-\n include/libcamera/internal/media_device.h | 2 +-\n include/libcamera/internal/v4l2_subdevice.h | 2 +-\n include/libcamera/internal/v4l2_videodevice.h | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex d79bd9ce9d58..eb464114cb3a 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -66,7 +66,7 @@ public:\n \tint sensorInfo(CameraSensorInfo *info) const;\n \n protected:\n-\tstd::string logPrefix() const;\n+\tstd::string logPrefix() const override;\n \n private:\n \tconst MediaEntity *entity_;\ndiff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\nindex 19af059d9291..20e397ccac49 100644\n--- a/include/libcamera/internal/media_device.h\n+++ b/include/libcamera/internal/media_device.h\n@@ -55,7 +55,7 @@ public:\n \tSignal<MediaDevice *> disconnected;\n \n protected:\n-\tstd::string logPrefix() const;\n+\tstd::string logPrefix() const override;\n \n private:\n \tint open();\ndiff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex 1be454f0ddda..07dc93d98776 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -62,7 +62,7 @@ public:\n \t\t\t\t\t const std::string &entity);\n \n protected:\n-\tstd::string logPrefix() const;\n+\tstd::string logPrefix() const override;\n \n private:\n \tstd::vector<unsigned int> enumPadCodes(unsigned int pad);\ndiff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex dc259523599c..cbaee6149f34 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -213,7 +213,7 @@ public:\n \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat);\n \n protected:\n-\tstd::string logPrefix() const;\n+\tstd::string logPrefix() const override;\n \n private:\n \tint getFormatMeta(V4L2DeviceFormat *format);\n", "prefixes": [ "libcamera-devel" ] }