Patch Detail
Show a patch.
GET /api/1.1/patches/3861/?format=api
{ "id": 3861, "url": "https://patchwork.libcamera.org/api/1.1/patches/3861/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3861/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200526142237.407557-3-jacopo@jmondi.org>", "date": "2020-05-26T14:22:31", "name": "[libcamera-devel,2/8] android: hal_manager: Report supported API version", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e5aeffe8423c90376d1d39c16853a8c52ed42e3c", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3861/mbox/", "series": [ { "id": 930, "url": "https://patchwork.libcamera.org/api/1.1/series/930/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=930", "date": "2020-05-26T14:22:29", "name": "android: Implament format translation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/930/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3861/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3861/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E29561075\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 May 2020 16:19:25 +0200 (CEST)", "from localhost.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 2459040004;\n\tTue, 26 May 2020 14:19:24 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 May 2020 16:22:31 +0200", "Message-Id": "<20200526142237.407557-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200526142237.407557-1-jacopo@jmondi.org>", "References": "<20200526142237.407557-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/8] android: hal_manager: Report\n\tsupported API version", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 May 2020 14:19:26 -0000" }, "content": "Report the supported API version in the camera_info structure provided\nto the framework.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_hal_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 759e320dcd3b..b02d8d1a8362 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -110,7 +110,7 @@ int CameraHalManager::getCameraInfo(unsigned int id, struct camera_info *info)\n \t/* \\todo Get these info dynamically inspecting the camera module. */\n \tinfo->facing = id ? CAMERA_FACING_FRONT : CAMERA_FACING_BACK;\n \tinfo->orientation = 0;\n-\tinfo->device_version = 0;\n+\tinfo->device_version = CAMERA_DEVICE_API_VERSION_3_3;\n \tinfo->resource_cost = 0;\n \tinfo->static_camera_characteristics = camera->getStaticMetadata();\n \tinfo->conflicting_devices = nullptr;\n", "prefixes": [ "libcamera-devel", "2/8" ] }