Patch Detail
Show a patch.
GET /api/1.1/patches/3829/?format=api
{ "id": 3829, "url": "https://patchwork.libcamera.org/api/1.1/patches/3829/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3829/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200520131942.444499-1-jacopo@jmondi.org>", "date": "2020-05-20T13:19:42", "name": "[libcamera-devel,v5] libcamera: properties: Define pixel array properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "28f26064ec66d852972b593e597e00505806054e", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3829/mbox/", "series": [ { "id": 918, "url": "https://patchwork.libcamera.org/api/1.1/series/918/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=918", "date": "2020-05-20T13:19:42", "name": "[libcamera-devel,v5] libcamera: properties: Define pixel array properties", "version": 5, "mbox": "https://patchwork.libcamera.org/series/918/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3829/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3829/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91698603F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 May 2020 15:16:26 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id DE1361C000B;\n\tWed, 20 May 2020 13:16:25 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 May 2020 15:19:42 +0200", "Message-Id": "<20200520131942.444499-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5] libcamera: properties: Define pixel\n\tarray properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 20 May 2020 13:16:26 -0000" }, "content": "Add definition of pixel array related properties.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n\nBroke out properties definition to fast track them\n\n---\n src/libcamera/property_ids.yaml | 198 ++++++++++++++++++++++++++++++++\n 1 file changed, 198 insertions(+)\n\n--\n2.26.2", "diff": "diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex ce627fa042ba..2ae178a73d52 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -386,4 +386,202 @@ controls:\n | |\n | |\n +--------------------+\n+\n+ - UnitCellSize:\n+ type: Size\n+ description: |\n+ The pixel unit cell physical size, in micro-meters.\n+\n+ The UnitCellSize properties defines the horizontal and vertical sizes\n+ of a single pixel unit.\n+\n+ The property can be used to calculate the physical size of the sensor's\n+ pixel array.\n+\n+\n+ - PixelArrayFullSize:\n+ type: Size\n+ description: |\n+ The camera sensor full pixel array vertical and horizontal sizes, in\n+ pixels.\n+\n+ The PixelArrayFullSize property defines the size of the full pixel\n+ array matrix, including blank pixels used for calibration, exposed\n+ pixels which are not considered valid for image capture and active\n+ pixels.\n+\n+ The property describes a rectangle whose top-left corner is placed\n+ in position (0, 0) and whose vertical and horizontal sizes are defined\n+ by the Size element transported by the property.\n+\n+ The PixelArrayEffectiveSize and PixelArrayActiveSize described\n+ rectangles are defined in respect to the rectangle described by this\n+ property.\n+\n+ \\todo Rename this property to FullSize once we will have property\n+ categories (i.e. Properties::PixelArray::FullSize)\n+\n+ - PixelArrayEffectiveSize:\n+ type: Rectangle\n+ description: |\n+ The PixelArrayEffectiveSize defines the portion of the camera sensor\n+ full pixel array matrix which is exposed to light but not valid for\n+ image acquisition purposes.\n+\n+ The PixelArrayEffectiveSize property defines the size in pixel units,\n+ and the position of effective pixels area rectangle relatively to the\n+ full pixel array matrix described by PixelArrayFullSize.\n+\n+ The Rectangle top-left corner is defined by its horizontal and vertical\n+ distances from pixel (0, 0) of the full pixel matrix array.\n+\n+ Example\n+ Given a full pixel array size rectangle, whose top-left corner is placed\n+ in position (0, 0) and its horizontal and vertical dimensions defined\n+ by PixelArrayFullSize[0] and PixelArrayFullSize[1] respectively\n+\n+\n+ PixelArrayFullSize[0]\n+ /-----------------/\n+ x1 x2\n+ (0,0)-> +-o------------o-+ /\n+ y1 o +------------+ | |\n+ | |////////////| | |\n+ | |////////////| | | PixelArrayFullSize[1]\n+ | |////////////| | |\n+ y2 o +------------+ | |\n+ +----------------+ /\n+\n+ The size and position of the effective pixel array rectangle is defined\n+ as follows\n+\n+ PixelArrayEffectiveSize = (x1, y1, x2 - x1 + 1, y2 - y1 + 1)\n+\n+ \\todo Rename this property to EffectiveSize once we will have property\n+ categories (i.e. Properties::PixelArray::EffectiveSize)\n+\n+ - PixelArrayActiveAreas:\n+ type: Rectangle\n+ size: [1 x n]\n+ description: |\n+ The PixelArrayActiveAreas property defines the (possibly multiple and\n+ overlapping) portions of the camera sensor effective pixel matrix\n+ which are considered valid for image acquisition purposes.\n+\n+ Each rectangle is defined relatively to the PixelArrayEffectiveSize\n+ rectangle, with its top-left corner defined by its horizontal and\n+ vertical distances from the PixelArrayEffectiveSize rectangle top-left\n+ corner.\n+\n+ This property describes an arbitrary number of overlapping rectangles,\n+ with each rectangle representing the maximum image size that the camera\n+ sensor can produce for a particular aspect ratio.\n+\n+ When multiple rectangles are reported, they shall be ordered from the\n+ tallest to the shortest.\n+\n+ Example 1\n+ A camera sensor which only produces images in the 4:3 image resolution\n+ will report a single PixelArrayActiveAreas rectangle, from which all\n+ other image formats are obtained by either cropping the field-of-view\n+ and/or applying pixel sub-sampling techniques such as pixel skipping or\n+ binning.\n+\n+ PixelArrayEffectiveSize[2]\n+ /-----------------/\n+ x1 x2\n+ +-o------------o-+ /\n+ y1 o +------------+ | |\n+ | |////////////| | |\n+ | |////////////| | | PixelArrayEffectiveSize[3]\n+ | |////////////| | |\n+ y2 o +------------+ | |\n+ +----------------+ /\n+\n+ The property reports a single rectangle\n+\n+ PixelArrayActiveAreas = (x1, y1, x2 - x1 + 1, y2 - y1 + 1)\n+\n+ Example 2\n+ A camera sensor which can produce images in different native\n+ resolutions will report several overlapping rectangles, one for each\n+ natively supported resolution.\n+\n+ PixelArrayEffectiveSize[2]\n+ /-----------------/\n+ x1 x2 x3 x4\n+ +o---o------o---o+ /\n+ y1 o +------+ | |\n+ | |//////| | |\n+ y2 o+---+------+---+| |\n+ ||///|//////|///|| | PixelArrayEffectiveSize[3]\n+ y3 o+---+------+---+| |\n+ | |//////| | |\n+ y4 o +------+ | |\n+ +----+------+----+ /\n+\n+ The property reports two rectangles\n+\n+ PixelArrayActiveAreas = ((x2, y1, x3 - x2 + 1, y4 - y1 + 1),\n+ (x1, y2, x4 - x1 + 1, y3 - y2 + 1))\n+\n+ The first rectangle describes the maximum field-of-view of all image\n+ formats in the 4:3 resolutions, while the second one describes the\n+ maximum field of view for all image formats in the 16:9 resolutions.\n+\n+ \\todo Rename this property to ActiveAreas once we will have property\n+ categories (i.e. Properties::PixelArray::ActiveAreas)\n+\n+ - ColorFilterArrangement:\n+ type: int32_t\n+ description: |\n+ The pixel array color filter arrangement.\n+\n+ This property describes the arrangement and readout sequence of the\n+ three RGB color components of the sensor's Color Filter Array (CFA).\n+\n+ Color filters are usually arranged in line-alternating fashion on the\n+ sensor pixel array. For example, one line might be composed of Red-Green\n+ while the successive is composed of Blue-Green color information.\n+\n+ For Bayer filters, the value of this property represents the arrangement\n+ of color filters in the top-left 2x2 pixel square.\n+\n+ For example, for a sensor with the following color filter pattern\n+\n+ (0, 0) (max-col)\n+ +---+ +--------------...---+\n+ |B|G|<---|B|G|B|G|B|G|B|...B|G|\n+ |G|R|<---|G|R|G|R|G|R|G|...G|R|\n+ +---+ |B|G|B|G|B|G|B|...B|G|\n+ ... ..\n+ ... ..\n+ |G|R|G|R|G|R|G|...G|R|\n+ |B|G|B|G|B|G|B|...B|G| (max-lines)\n+ +--------------...---+\n+\n+ The filter arrangement is represented by the BGGR value, which\n+ correspond to the pixel readout sequence in line interleaved mode.\n+\n+ enum:\n+ - name: BayerFilterBGGR\n+ value: 0\n+ description: |\n+ Bayer color filter array arrangement is Blue-Green/Green-Red\n+\n+ - name: BayerFilterGBRG\n+ value: 1\n+ description: |\n+ Bayer color filter array arrangement is Green-Blue/Red-Green\n+\n+ - name: BayerFilterGRBG\n+ value: 2\n+ description: |\n+ Bayer color filter array arrangement is Green-Red/Blue-Green\n+\n+ - name: BayerFilterRGGB\n+ value: 3\n+ description: |\n+ Bayer color filter array arrangement is Red-Green/Green-Blue\n+\n ...\n", "prefixes": [ "libcamera-devel", "v5" ] }