Patch Detail
Show a patch.
GET /api/1.1/patches/3804/?format=api
{ "id": 3804, "url": "https://patchwork.libcamera.org/api/1.1/patches/3804/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3804/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200518105129.9867-1-laurent.pinchart@ideasonboard.com>", "date": "2020-05-18T10:51:29", "name": "[libcamera-devel,v2] (q)cam: Fix header guards", "commit_ref": "a237dbeb7e2238beea7222bafe75f8a0d912c4af", "pull_url": null, "state": "accepted", "archived": false, "hash": "a20a557ecba9bc5bdac2f87fe0032700765ee291", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3804/mbox/", "series": [ { "id": 908, "url": "https://patchwork.libcamera.org/api/1.1/series/908/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=908", "date": "2020-05-18T10:51:29", "name": "[libcamera-devel,v2] (q)cam: Fix header guards", "version": 2, "mbox": "https://patchwork.libcamera.org/series/908/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3804/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3804/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3CD3603DB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 May 2020 12:51:41 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B15B9258\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 May 2020 12:51:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EiV0kQpW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589799100;\n\tbh=X39WWD6tSoCd480iuPT20Lpqfc6CMONSFJXSetE5AQQ=;\n\th=From:To:Subject:Date:From;\n\tb=EiV0kQpWeCU6c0dUqnICxJz9v/E3gGH8Ww5UnbXyw5RUetfOeEj1mVUguYoKN94gG\n\tY1VeYHvS+6hiJ0GQNO3boQ3+llGqyb8uGOBzgm8weAucxQhwv+oEentavPEzJuEfxV\n\t+wMaBg9NEDv2HyKBXgsVtNtYs1NB8S8vNbBfX/44=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 18 May 2020 13:51:29 +0300", "Message-Id": "<20200518105129.9867-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] (q)cam: Fix header guards", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 18 May 2020 10:51:42 -0000" }, "content": "Several headers part of cam and qcam use __LIBCAMERA_*_H__ as a header\nguard. They're not part of the libcamera core, use __CAM_*_H__ and\n__QCAM_*_H__ instead, similarly to all other headers of cam and qcam.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/buffer_writer.h | 6 +++---\n src/qcam/dng_writer.h | 6 +++---\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/cam/buffer_writer.h b/src/cam/buffer_writer.h\nindex 8c9b2436fdae..47e26103e13e 100644\n--- a/src/cam/buffer_writer.h\n+++ b/src/cam/buffer_writer.h\n@@ -4,8 +4,8 @@\n *\n * buffer_writer.h - Buffer writer\n */\n-#ifndef __LIBCAMERA_BUFFER_WRITER_H__\n-#define __LIBCAMERA_BUFFER_WRITER_H__\n+#ifndef __CAM_BUFFER_WRITER_H__\n+#define __CAM_BUFFER_WRITER_H__\n \n #include <map>\n #include <string>\n@@ -28,4 +28,4 @@ private:\n \tstd::map<int, std::pair<void *, unsigned int>> mappedBuffers_;\n };\n \n-#endif /* __LIBCAMERA_BUFFER_WRITER_H__ */\n+#endif /* __CAM_BUFFER_WRITER_H__ */\ndiff --git a/src/qcam/dng_writer.h b/src/qcam/dng_writer.h\nindex d74d73d06a14..bf44c879aff7 100644\n--- a/src/qcam/dng_writer.h\n+++ b/src/qcam/dng_writer.h\n@@ -4,8 +4,8 @@\n *\n * dng_writer.h - DNG writer\n */\n-#ifndef __LIBCAMERA_DNG_WRITER_H__\n-#define __LIBCAMERA_DNG_WRITER_H__\n+#ifndef __QCAM_DNG_WRITER_H__\n+#define __QCAM_DNG_WRITER_H__\n \n #ifdef HAVE_TIFF\n #define HAVE_DNG\n@@ -28,4 +28,4 @@ public:\n \n #endif /* HAVE_TIFF */\n \n-#endif /* __LIBCAMERA_DNG_WRITER_H__ */\n+#endif /* __QCAM_DNG_WRITER_H__ */\n", "prefixes": [ "libcamera-devel", "v2" ] }