Patch Detail
Show a patch.
GET /api/1.1/patches/3798/?format=api
{ "id": 3798, "url": "https://patchwork.libcamera.org/api/1.1/patches/3798/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3798/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200515124245.18040-3-email@uajain.com>", "date": "2020-05-15T12:42:52", "name": "[libcamera-devel,v2,2/4] test: log: log_process: Close open fds on error paths", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "94e1012fd3953773e5bc45b4ea35ec36ed320f42", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3798/mbox/", "series": [ { "id": 905, "url": "https://patchwork.libcamera.org/api/1.1/series/905/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=905", "date": "2020-05-15T12:42:52", "name": "Coverity scan fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/905/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3798/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3798/checks/", "tags": {}, "headers": { "Return-Path": "<bounces+15657259-5c31-libcamera-devel=lists.libcamera.org@em7280.uajain.com>", "Received": [ "from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2BFF60E13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 May 2020 14:42:54 +0200 (CEST)", "by filter0084p3las1.sendgrid.net with SMTP id\n\tfilter0084p3las1-1974-5EBE8E4C-A1\n\t2020-05-15 12:42:52.854806595 +0000 UTC m=+2558464.992313740", "from mail.uajain.com (unknown)\n\tby ismtpd0005p1maa1.sendgrid.net (SG) with ESMTP\n\tid Bb31tzGJTlujrBoPAJbqoA Fri, 15 May 2020 12:42:52.252 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"Jks/uQxm\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=hidbZmSCedH/UeQG+0jv3X5RNRj/EkzKOHm8deO5gWc=;\n\tb=Jks/uQxmQKIOk0RnN+eZ9xa5S9OgjKiw93iZBs6fWn+FeCQEk5pAauMhb5GWz0ARoVc3\n\tEzUXmbYs3nv698XY/TNuq42eBOL64jbazfqxS3A47Kcxzbnn3D0rBI0YKgfgQJSNuvxagr\n\tZqmDjZdjlBiovXtBUECGPUPxzQk53yzy0=", "From": "Umang Jain <email@uajain.com>", "Date": "Fri, 15 May 2020 12:42:52 +0000 (UTC)", "Message-Id": "<20200515124245.18040-3-email@uajain.com>", "In-Reply-To": "<20200515124245.18040-1-email@uajain.com>", "References": "<20200515124245.18040-1-email@uajain.com>", "Mime-Version": "1.0", "X-SG-EID": "1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcofpXQ1KwJPJayd5tGsU1eE0zU8daDke3ehhqRL/kdCxt6mtbjh37tkVljdm4f4vWvqsgOrdrY9upOA2muDKs5nB+vNHsfvcyHnyHhIbiFJB11jE/WP5UHPJvn909pI48egvoXqHN56y3rAB7G7LaR2sy4Pim5FJ434utqowL7SLsouqkjOSppkW4RsgBetSW", "To": "libcamera-devel <libcamera-devel@lists.libcamera.org>", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=us-ascii", "Subject": "[libcamera-devel] [PATCH v2 2/4] test: log: log_process: Close open\n\tfds on error paths", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 15 May 2020 12:42:55 -0000" }, "content": "Pointed out by Coverity DefectId=279097\n\nSigned-off-by: Umang Jain <email@uajain.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n test/log/log_process.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\nindex 2df4aa4..88baa27 100644\n--- a/test/log/log_process.cpp\n+++ b/test/log/log_process.cpp\n@@ -106,6 +106,7 @@ protected:\n \t\tmemset(buf, 0, sizeof(buf));\n \t\tif (read(fd, buf, sizeof(buf)) < 0) {\n \t\t\tcerr << \"Failed to read tmp log file\" << endl;\n+\t\t\tclose(fd);\n \t\t\treturn TestFail;\n \t\t}\n \t\tclose(fd);\n", "prefixes": [ "libcamera-devel", "v2", "2/4" ] }